Add timestamp to secondary status for traning job logs #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
previously approved these changes
Oct 12, 2018
laurenyu
approved these changes
Oct 12, 2018
iquintero
reviewed
Oct 12, 2018
| status_strs.append('{} {} - {}'.format(time_str, transition['Status'], message)) | ||
|
|
||
| return '\n'.join(status_strs) | ||
| transitions_to_print = current_transitions[-1:] if len(current_transitions) == prev_transitions_num else \ |
There was a problem hiding this comment.
Can you replace this \ ?
it probably makes sense to split this and add a comment on what the intended state on each branch is? its not very obvious.
https://github.com/google/styleguide/blob/gh-pages/pyguide.md#32-line-length
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
* Add timestamp to secondary status for training job output * Modify changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available
Description of changes:
After this change the output of training job looks like this:
INFO:sagemaker:Creating training-job with name: sagemaker-mxnet-2018-10-11-22-39-27-822
2018-10-11 22:39:29 Starting - Starting the training job...
2018-10-11 22:39:29 Starting - Launching requested ML instances......
2018-10-11 22:40:30 Starting - Preparing the instances for training......
2018-10-11 22:41:53 Downloading - Downloading input data..
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.