feat: jumpstart extract generated text from response #4210

evakravi · 2023-10-17T20:36:21Z

Issue #, if available:

Description of changes:
feat: jumpstart extract generated text from response

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-10-17T20:38:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 17fe452
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-17T21:33:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 17fe452
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-17T21:42:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 17fe452
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-17T21:42:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 17fe452
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-response

sagemaker-bot · 2023-10-17T23:18:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 441343d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T00:13:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 441343d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T00:20:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 441343d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T00:27:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 441343d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T01:12:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 441343d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JGuinegagne · 2023-10-18T17:58:15Z

tests/unit/sagemaker/jumpstart/constants.py

@@ -1781,6 +1781,169 @@
            },
        },
    },
+    "response-keys": {


same comment please, consider: response-keys-model

sagemaker-bot · 2023-10-18T19:09:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 91cb900
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T19:19:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 91cb900
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T19:35:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 91cb900
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T20:04:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 91cb900
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-10-18T20:04:58Z

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (3057f21) 90.27% compared to head (da1bc60) 90.25%.
Report is 53 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4210      +/-   ##
==========================================
- Coverage   90.27%   90.25%   -0.02%     
==========================================
  Files         993      320     -673     
  Lines       87861    29739   -58122     
==========================================
- Hits        79313    26840   -52473     
+ Misses       8548     2899    -5649

Files	Coverage Δ
src/sagemaker/base_predictor.py	`90.90% <100.00%> (ø)`
src/sagemaker/config/config_schema.py	`100.00% <100.00%> (ø)`
src/sagemaker/djl_inference/model.py	`91.11% <100.00%> (ø)`
src/sagemaker/estimator.py	`92.88% <ø> (ø)`
src/sagemaker/feature_store/feature_group.py	`78.82% <ø> (ø)`
...emaker/feature_store/feature_processor/__init__.py	`100.00% <100.00%> (ø)`
...eature_store/feature_processor/_config_uploader.py	`97.43% <100.00%> (ø)`
...aker/feature_store/feature_processor/_constants.py	`100.00% <100.00%> (ø)`
...er/feature_store/feature_processor/_data_source.py	`100.00% <100.00%> (ø)`
...agemaker/feature_store/feature_processor/_enums.py	`100.00% <100.00%> (ø)`
... and 51 more

... and 1252 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sagemaker-bot · 2023-10-19T02:16:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 91cb900
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-response

sagemaker-bot · 2023-10-19T16:23:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0be4fd5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T16:24:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0be4fd5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T16:31:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0be4fd5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T17:20:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0be4fd5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T23:28:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0be4fd5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…erated-text-from-response

sagemaker-bot · 2023-10-20T16:53:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 20b5b66
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T17:44:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 20b5b66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T17:51:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 20b5b66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T17:56:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 20b5b66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T18:21:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 20b5b66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T19:30:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: da1bc60
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T19:45:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: da1bc60
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T19:50:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: da1bc60
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T20:20:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: da1bc60
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-20T20:32:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: da1bc60
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feat: jumpstart extract generated text from response

17fe452

evakravi requested a review from a team as a code owner October 17, 2023 20:36

evakravi requested review from akrishna1995 and removed request for a team October 17, 2023 20:36

Merge branch 'master' into feat/jumpstart-extract-generated-text-from…

441343d

…-response

JGuinegagne approved these changes Oct 18, 2023

View reviewed changes

fix: typing

91cb900

mufaddal-rohawala self-assigned this Oct 18, 2023

mufaddal-rohawala removed the request for review from akrishna1995 October 18, 2023 18:18

Merge branch 'master' into feat/jumpstart-extract-generated-text-from…

0be4fd5

…-response

Merge remote-tracking branch 'origin' into feat/jumpstart-extract-gen…

20b5b66

…erated-text-from-response

fix: pydocstyle

da1bc60

knikure approved these changes Oct 20, 2023

View reviewed changes

knikure merged commit 4befd93 into aws:master Oct 20, 2023

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Oct 23, 2023

feat: jumpstart extract generated text from response (aws#4210)

e198325

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: jumpstart extract generated text from response #4210

feat: jumpstart extract generated text from response #4210

evakravi commented Oct 17, 2023

sagemaker-bot commented Oct 17, 2023

sagemaker-bot commented Oct 17, 2023

sagemaker-bot commented Oct 17, 2023

sagemaker-bot commented Oct 17, 2023

sagemaker-bot commented Oct 17, 2023

sagemaker-bot commented Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

JGuinegagne Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

sagemaker-bot commented Oct 18, 2023

codecov-commenter commented Oct 18, 2023 •

edited

Loading

sagemaker-bot commented Oct 19, 2023

sagemaker-bot commented Oct 19, 2023

sagemaker-bot commented Oct 19, 2023

sagemaker-bot commented Oct 19, 2023

sagemaker-bot commented Oct 19, 2023

sagemaker-bot commented Oct 19, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

sagemaker-bot commented Oct 20, 2023

feat: jumpstart extract generated text from response #4210

feat: jumpstart extract generated text from response #4210

Conversation

evakravi commented Oct 17, 2023

Merge Checklist

General

Tests

sagemaker-bot commented Oct 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

JGuinegagne Oct 18, 2023

Choose a reason for hiding this comment

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

codecov-commenter commented Oct 18, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2023

AWS CodeBuild CI Report

codecov-commenter commented Oct 18, 2023 •

edited

Loading