Skip to content

Enable using short-lived credentials in Local mode (#403) #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Enable using short-lived credentials in Local mode (#403) #418

merged 2 commits into from
Oct 5, 2018

Conversation

humanzz
Copy link
Contributor

@humanzz humanzz commented Oct 4, 2018

Issue #, if available: #403

*Description of changes: Enable using short lived credentials in local mode

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #418 into master will increase coverage by 0.07%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   93.36%   93.44%   +0.07%     
==========================================
  Files          53       53              
  Lines        3724     3737      +13     
==========================================
+ Hits         3477     3492      +15     
+ Misses        247      245       -2
Impacted Files Coverage Δ
src/sagemaker/local/image.py 88.53% <93.33%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd44d25...32a0055. Read the comment docs.

Copy link
Contributor

@iquintero iquintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. It looks great.

@ChoiByungWook ChoiByungWook merged commit d9c03a1 into aws:master Oct 5, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants