Skip to content

deprecation: remove explicit partitions key requirement on pysdk side. #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023
Merged

deprecation: remove explicit partitions key requirement on pysdk side. #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/sagemaker/fw_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,6 @@ def validate_mp_config(config):
ValueError: If any of the keys have incorrect values.
"""

if "partitions" not in config:
raise ValueError("'partitions' is a required parameter.")

def validate_positive(key):
try:
if not isinstance(config[key], int) or config[key] < 1:
Expand Down
6 changes: 0 additions & 6 deletions tests/unit/test_fw_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,6 @@ def test_tar_and_upload_dir_s3_without_kms_with_overridden_settings(utils, sagem
obj.upload_file.assert_called_with(utils.create_tar_file(), ExtraArgs=None)


def test_mp_config_partition_exists():
mp_parameters = {}
with pytest.raises(ValueError):
fw_utils.validate_mp_config(mp_parameters)


@pytest.mark.parametrize(
"pipeline, placement_strategy, optimize, trace_device",
[
Expand Down