-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: jumpstart cache using sagemaker session s3 client #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
63431d5
fix: jumpstart cache using sagemaker session s3 client
evakravi e99cb3c
fix: docstring
evakravi e070e78
Merge branch 'master' into fix/js-cache-s3-client
evakravi c7d3bd2
fix: unit tests
evakravi 5ce011b
fix: docstring
evakravi 87da5bc
fix: docstring
evakravi fd5f890
fix: cache kwargs
evakravi 31f2568
chore: cleanup git diff
evakravi 1125c4f
chore: improve docstring
evakravi f028263
Merge branch 'master' into fix/js-cache-s3-client
evakravi 3718701
Merge branch 'master' into fix/js-cache-s3-client
evakravi 83279a8
Merge branch 'master' into fix/js-cache-s3-client
evakravi c6fb8bd
fix: line too long
evakravi 6ec4e8d
chore: cleanup code from PR comment
evakravi d72ff42
Merge branch 'master' into fix/js-cache-s3-client
evakravi 12678bc
fix: model package arn unit test
evakravi 7e96f0e
fix: failing test_new_session_created
evakravi b2d281c
fix: reset cache if content bucket changes
evakravi b246739
Merge branch 'master' into fix/js-cache-s3-client
evakravi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please review this docstring with @judyheflin ?