Skip to content

Mvs local mode timeout #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Sep 25, 2018

Description of changes:

Setting health check timeout limit on local mode to match the limit defined by the docs https://docs.aws.amazon.com/sagemaker/latest/dg/your-algorithms-inference-code.html#your-algorithms-inference-algo-ping-requests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Sep 25, 2018

Codecov Report

Merging #401 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   93.11%   92.94%   -0.17%     
==========================================
  Files          51       51              
  Lines        3572     3573       +1     
==========================================
- Hits         3326     3321       -5     
- Misses        246      252       +6
Impacted Files Coverage Δ
src/sagemaker/local/local_session.py 80.18% <100%> (+0.18%) ⬆️
src/sagemaker/local/image.py 87.42% <0%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb68540...00885b4. Read the comment docs.

@iquintero
Copy link
Contributor

Please change the title of the PR/Commit when you merge.
'Adjust local mode timeout to match SageMaker' or something like that.

@iquintero
Copy link
Contributor

Closing in favor of #375

@iquintero iquintero closed this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants