-
Notifications
You must be signed in to change notification settings - Fork 1.2k
documentation: fix wait_for_endpoint docstring #3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In aws#1204, the `wait_for_endpoint` `poll` default was changed from 5 to 30, but the docstring wasn't updated. Update the docstring to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run all
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
- Coverage 90.32% 89.60% -0.73%
==========================================
Files 1296 306 -990
Lines 114152 28233 -85919
==========================================
- Hits 103108 25298 -77810
+ Misses 11044 2935 -8109
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available: None.
Description of changes: In #1204, the
wait_for_endpoint
poll
default was changed from 5 to 30, but the docstring wasn't updated. Update the docstring to match.Testing done: None.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.