fix: skip intelligent volume_size allocation based on instance type if it is a pipeline parameter #3972

jerrypeng7773 · 2023-06-30T18:58:37Z

Issue #, if available:

Description of changes:

fix: skip intelligent volume_size allocation based on instance type if it is a pipeline parameter

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…f it is a pipeline parameter

sagemaker-bot · 2023-06-30T19:36:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1a6a567
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T19:37:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1a6a567
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T19:41:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1a6a567
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T19:49:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1a6a567
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T19:52:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1a6a567
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T19:55:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1a6a567
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T20:32:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1a6a567
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-06-30T20:32:37Z

Codecov Report

Merging #3972 (8081798) into master (052d7e0) will decrease coverage by 0.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3972      +/-   ##
==========================================
- Coverage   90.31%   89.59%   -0.73%     
==========================================
  Files        1292      305     -987     
  Lines      114012    28198   -85814     
==========================================
- Hits       102968    25263   -77705     
+ Misses      11044     2935    -8109

Impacted Files	Coverage Δ
src/sagemaker/utils.py	`94.79% <100.00%> (ø)`

... and 1596 files with indirect coverage changes

sagemaker-bot · 2023-06-30T20:32:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1a6a567
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T21:30:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1e312e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T21:39:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1e312e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T21:43:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1e312e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T22:26:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1e312e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T23:50:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 185418a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T23:53:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 185418a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-01T00:03:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 185418a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-01T00:23:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 185418a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-01T00:48:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 185418a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T17:35:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8081798
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T17:39:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8081798
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T17:47:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8081798
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T18:31:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8081798
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T20:22:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8081798
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-05T01:04:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8081798
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-05T17:35:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8081798
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sthodimi

LGTM, all checks passed

jerrypeng7773 and others added 2 commits June 30, 2023 11:54

fix: skip intelligent volume_size allocation based on instance type i…

29b5a94

…f it is a pipeline parameter

Merge branch 'master' into master

1a6a567

jerrypeng7773 closed this Jun 30, 2023

fix: Change the order of the if statement check.

1e312e5

jerrypeng7773 reopened this Jun 30, 2023

Merge branch 'master' into master

185418a

jerrypeng7773 marked this pull request as ready for review June 30, 2023 23:14

jerrypeng7773 requested a review from a team as a code owner June 30, 2023 23:14

jerrypeng7773 requested review from sthodimi and removed request for a team June 30, 2023 23:14

This was referenced Jun 30, 2023

Error when Estimator instance_type is a ParameterString #3968

Closed

Passing instance type as a ParameterString to PyTorch estimator in 2.163.0 crashes #3917

Closed

Merge branch 'master' into master

8081798

knikure assigned sthodimi Jul 5, 2023

sthodimi approved these changes Jul 5, 2023

View reviewed changes

sthodimi merged commit af837ae into aws:master Jul 5, 2023

brockwade633 mentioned this pull request Jul 10, 2023

Pipeline AttributeError: 'ParameterString' object has no attribute 'startswith #3974

Closed

qidewenwhen mentioned this pull request Aug 5, 2023

ValueError(f"Bad value for instance type: '{instance_type}'") #3993

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: skip intelligent volume_size allocation based on instance type if it is a pipeline parameter #3972

fix: skip intelligent volume_size allocation based on instance type if it is a pipeline parameter #3972

jerrypeng7773 commented Jun 30, 2023 •

edited

Loading

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

codecov-commenter commented Jun 30, 2023 •

edited

Loading

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jun 30, 2023

sagemaker-bot commented Jul 1, 2023

sagemaker-bot commented Jul 1, 2023

sagemaker-bot commented Jul 1, 2023

sagemaker-bot commented Jul 3, 2023

sagemaker-bot commented Jul 3, 2023

sagemaker-bot commented Jul 3, 2023

sagemaker-bot commented Jul 3, 2023

sagemaker-bot commented Jul 3, 2023

sagemaker-bot commented Jul 5, 2023

sagemaker-bot commented Jul 5, 2023

sthodimi left a comment

fix: skip intelligent volume_size allocation based on instance type if it is a pipeline parameter #3972

fix: skip intelligent volume_size allocation based on instance type if it is a pipeline parameter #3972

Conversation

jerrypeng7773 commented Jun 30, 2023 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

codecov-commenter commented Jun 30, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 1, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 1, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 1, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 5, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 5, 2023

AWS CodeBuild CI Report

sthodimi left a comment

Choose a reason for hiding this comment

jerrypeng7773 commented Jun 30, 2023 •

edited

Loading

codecov-commenter commented Jun 30, 2023 •

edited

Loading