Skip to content

Adding PDT region account for 1p algorithms #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2018
Merged

Adding PDT region account for 1p algorithms #391

merged 6 commits into from
Sep 27, 2018

Conversation

ericangelokim
Copy link
Contributor

Added PDT Account ID to Amazon Estimator.

Note: LDA is missing because we won't be deployed to LDA by launch date due to infrastructure problems. Will be working on this after initial launch.

Note: My commits are a little funky, I didn't realize the Pull Request I made to sync my fork to aws/master would create a new commit.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ x] I have updated the changelog with a description of my changes (if appropriate)
  • [ x] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          52       52           
  Lines        3665     3665           
=======================================
  Hits         3424     3424           
  Misses        241      241
Impacted Files Coverage Δ
src/sagemaker/amazon/amazon_estimator.py 88.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee51e9...3a2fd4b. Read the comment docs.

@ChoiByungWook ChoiByungWook merged commit dbbe9a4 into aws:master Sep 27, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants