-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Document upcoming MXNet training script format #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laurenyu
merged 20 commits into
aws:master
from
laurenyu:mxnet-script-mode-readme-warning
Sep 18, 2018
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c2dc20b
Start adding documentation about upcoming MXNet training script changes
laurenyu c52ad94
attempt to fix formatting
laurenyu 83245c5
attempt to fix formatting
laurenyu 2764427
attempt to fix formatting
laurenyu ffe9bfe
attempt to fix formatting
laurenyu 891bf59
attempt to fix formatting
laurenyu 66b9572
Revert "attempt to fix formatting"
laurenyu 11dccfd
fix link
laurenyu 5f4a303
begin writing instructions
laurenyu 518760b
attempt to fix formatting
laurenyu 614cdcc
attempt to fix formatting
laurenyu a16ad86
attempt to fix formatting
laurenyu c71d44f
attempt to fix formatting
laurenyu e2eb318
Continue writing
laurenyu d790884
attempt to fix formatting
laurenyu bb0b3f4
Continue writing
laurenyu 0e6a49a
tweak wording
laurenyu 9f97499
Merge branch 'master' into mxnet-script-mode-readme-warning
laurenyu 9695cd5
add details about env variables
laurenyu 880a238
tweak wording
laurenyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest replacing "will be" with "are"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used future tense because these instructions are going to be live awhile before the changes themselves are released - I'm afraid present tense might be too confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough