Skip to content

change: remove unnecessary log messages for loading existing experiment runs #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

leoroy
Copy link
Contributor

@leoroy leoroy commented May 24, 2023

Issue #, if available: 3881

Description of changes: update the log message to remove the suggestion to use load_run

Testing done: unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leoroy leoroy requested a review from a team as a code owner May 24, 2023 05:12
@leoroy leoroy requested review from claytonparnell and removed request for a team May 24, 2023 05:12
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 2a0bdd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 2a0bdd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 2a0bdd2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 2a0bdd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2a0bdd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Merging #3882 (2a0bdd2) into master (0f37695) will decrease coverage by 0.59%.
The diff coverage is 93.64%.

@@            Coverage Diff             @@
##           master    #3882      +/-   ##
==========================================
- Coverage   89.96%   89.37%   -0.59%     
==========================================
  Files        1140      269     -871     
  Lines      105744    26208   -79536     
==========================================
- Hits        95129    23424   -71705     
+ Misses      10615     2784    -7831     
Impacted Files Coverage Δ
src/sagemaker/experiments/run.py 99.14% <ø> (ø)
src/sagemaker/huggingface/processing.py 100.00% <ø> (ø)
src/sagemaker/model_monitor/data_capture_config.py 68.75% <ø> (ø)
src/sagemaker/model_monitor/model_monitoring.py 69.60% <ø> (ø)
src/sagemaker/model_monitor/monitoring_files.py 42.15% <ø> (ø)
src/sagemaker/pytorch/model.py 96.82% <ø> (ø)
src/sagemaker/remote_function/job.py 88.93% <ø> (ø)
src/sagemaker/tensorflow/estimator.py 93.02% <0.00%> (ø)
src/sagemaker/workflow/clarify_check_step.py 96.91% <ø> (ø)
src/sagemaker/workflow/pipeline.py 95.03% <0.00%> (ø)
... and 24 more

... and 1375 files with indirect coverage changes

Copy link
Collaborator

@claytonparnell claytonparnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 2a0bdd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@claytonparnell claytonparnell merged commit b5b133a into aws:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove logs messages that confuse customers when loading existing runs
4 participants