feature: handle use case where endpoint is created outside of python … #3867

doddaspk-amzn · 2023-05-17T20:38:14Z

feature: handle use case where endpoint is created outside of python sdk with failure path as None

Issue #, if available:

Description of changes: Updating the predictor (async predictor) to handle the endpoints that are created outside of python sdk (say console) with failure path as None

Testing done: Manual & Unit Tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[X ] I have read the CONTRIBUTING doc
[ X] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
[ X] I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[X ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ X] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ X] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[ X] I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…sdk with failure path as None

sagemaker-bot · 2023-05-17T20:46:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ba959bb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-17T21:50:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c9bab0d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-17T21:57:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c9bab0d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-17T22:13:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c9bab0d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-17T22:15:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c9bab0d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-17T22:22:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c9bab0d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

bhaoz · 2023-05-17T23:27:09Z

src/sagemaker/async_inference/async_inference_response.py

@@ -87,8 +87,31 @@ def get_result(
        return self._result

    def _get_result_from_s3(self, output_path, failure_path):
+        """Retrieve output based on the presense of failure_path"""


Lgtm - synced with Praneeth offline as well; we'll track a backlog item to go back to SageMaker Python SDK again and add Integ tests for edge case where customers created Async endpoint without failure path and loaded in Python SDK for invocation usage.

knikure

/bot run notebook-tests

sagemaker-bot · 2023-05-18T01:10:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c9bab0d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-05-18T01:10:48Z

Codecov Report

Merging #3867 (c9bab0d) into master (4bc49e5) will decrease coverage by 0.72%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##           master    #3867      +/-   ##
==========================================
- Coverage   89.96%   89.24%   -0.72%     
==========================================
  Files        1140      267     -873     
  Lines      105616    26127   -79489     
==========================================
- Hits        95021    23318   -71703     
+ Misses      10595     2809    -7786

Impacted Files	Coverage Δ
...emaker/async_inference/async_inference_response.py	`82.00% <76.92%> (ø)`
src/sagemaker/predictor_async.py	`91.85% <87.50%> (ø)`

... and 1405 files with indirect coverage changes

sagemaker-bot · 2023-05-18T06:19:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c9bab0d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feature: handle use case where endpoint is created outside of python …

ba959bb

…sdk with failure path as None

doddaspk-amzn marked this pull request as ready for review May 17, 2023 20:41

doddaspk-amzn requested a review from a team as a code owner May 17, 2023 20:41

doddaspk-amzn requested review from trajanikant and removed request for a team May 17, 2023 20:41

address black-check format issues

c9bab0d

bhaoz reviewed May 17, 2023

View reviewed changes

bhaoz approved these changes May 17, 2023

View reviewed changes

knikure reviewed May 18, 2023

View reviewed changes

knikure self-assigned this May 18, 2023

knikure approved these changes May 18, 2023

View reviewed changes

knikure merged commit 0f37695 into aws:master May 18, 2023

knikure mentioned this pull request May 18, 2023

feature: handle use case where an endpoint is created outside of pyth… #3865

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: handle use case where endpoint is created outside of python … #3867

feature: handle use case where endpoint is created outside of python … #3867

doddaspk-amzn commented May 17, 2023 •

edited

Loading

sagemaker-bot commented May 17, 2023

sagemaker-bot commented May 17, 2023

sagemaker-bot commented May 17, 2023

sagemaker-bot commented May 17, 2023

sagemaker-bot commented May 17, 2023

sagemaker-bot commented May 17, 2023

bhaoz May 17, 2023

knikure left a comment •

edited

Loading

sagemaker-bot commented May 18, 2023

codecov-commenter commented May 18, 2023

sagemaker-bot commented May 18, 2023

feature: handle use case where endpoint is created outside of python … #3867

feature: handle use case where endpoint is created outside of python … #3867

Conversation

doddaspk-amzn commented May 17, 2023 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented May 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented May 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented May 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented May 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented May 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented May 17, 2023

AWS CodeBuild CI Report

bhaoz May 17, 2023

Choose a reason for hiding this comment

knikure left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented May 18, 2023

AWS CodeBuild CI Report

codecov-commenter commented May 18, 2023

Codecov Report

sagemaker-bot commented May 18, 2023

AWS CodeBuild CI Report

doddaspk-amzn commented May 17, 2023 •

edited

Loading

knikure left a comment •

edited

Loading