-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Remove deprecated update_endpoint from deploy() args in TensorFlowModel #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove deprecated update_endpoint from deploy() args in TensorFlowModel #3824
Conversation
Update_endpoint is a deprecated positional arg. Moved to kwargs to get rid of annoying warning: ``` DeprecationWarning: update_endpoint is a no-op in sagemaker>=2. ```
e0d7443
to
c6a54bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run all
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@ivan-khvostishkov Can you also fix the documentation errors for this change since it is failing in Sphinx? |
Could you please point me to these errors? I can only see timeouts in unit tests and I believe they are unrelated to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run unit-tests
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3824 +/- ##
==========================================
- Coverage 89.89% 89.15% -0.74%
==========================================
Files 1060 247 -813
Lines 101188 25042 -76146
==========================================
- Hits 90962 22326 -68636
+ Misses 10226 2716 -7510
|
Issue #, if available:
N/A
Description of changes:
Update_endpoint is a deprecated positional arg. Moved to deploy() kwargs to get rid of annoying warning when using TensorFlowModel:
Testing done:
Yes
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.