Skip to content

Allow argument for test framework version and mark regional tests #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Sep 5, 2018

Issue #, if available:

Description of changes:

  1. Allow passing argument for test framework version in pytest
  2. Mark regional tests for image deployment test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #382 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #382      +/-   ##
=========================================
- Coverage   92.99%   92.9%   -0.09%     
=========================================
  Files          51      51              
  Lines        3568    3568              
=========================================
- Hits         3318    3315       -3     
- Misses        250     253       +3
Impacted Files Coverage Δ
src/sagemaker/local/image.py 87.42% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3dceb...6f2e3a0. Read the comment docs.

@jesterhazy jesterhazy merged commit e9093fb into aws:master Sep 5, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
…s#382)

* Allow argument for test framework version and mark regional tests

* correct typo
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Update tensorflow notebooks to use sagemaker tensorflow container 1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants