Sagemaker Config for SDK Defaults #3757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Balaji Sankar <[email protected]>
* feature: sagemaker config - support tags for all APIs * feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs --------- Co-authored-by: Ruban Hussain <[email protected]>
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects * feature: sagemaker-config - support for custom parameters in config schema --------- Co-authored-by: Ruban Hussain <[email protected]>
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846) Co-authored-by: Balaji Sankar <[email protected]>
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849) Co-authored-by: Balaji Sankar <[email protected]>
…logic to accommodate that case (aws#850) Co-authored-by: Balaji Sankar <[email protected]>
…nd simplified its code
…d print statements
…atible behavior, and improved some unit tests
…e_endpoint_config_from_existing
…ating NetworkConfig
… for ValidationProfiles
… for config injection
… minor documentation updates.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
added 3 commits
March 28, 2023 15:01
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
/bot run pr |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40%
==========================================
Files 984 233 -751
Lines 92388 23379 -69009
==========================================
- Hits 83012 20914 -62098
+ Misses 9376 2465 -6911
... and 1170 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
evakravi
pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
* feature: Added Config parser for SageMaker Python SDK (aws#840) Co-authored-by: Balaji Sankar <[email protected]> * intelligent defaults - tags and encryption (aws#842) * feature: sagemaker config - support tags for all APIs * feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs --------- Co-authored-by: Ruban Hussain <[email protected]> * intelligent defaults - custom parameters and small fixes (aws#845) * fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects * feature: sagemaker-config - support for custom parameters in config schema --------- Co-authored-by: Ruban Hussain <[email protected]> * feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846) Co-authored-by: Balaji Sankar <[email protected]> * fix: Make Key, Value as required fields for each "Tags" entry in the config file. * fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849) Co-authored-by: Balaji Sankar <[email protected]> * Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850) Co-authored-by: Balaji Sankar <[email protected]> * fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring * change: Sagemaker Config - improved readability of print statements and simplified its code * fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements * fix: Sagemaker Config - add function description * fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests * change: new integ test for sagemaker_config * fix: Sagemaker Config - fleshed out unit tests and fixed bugs * fix: Sagemaker Config - Removed hard coded config values in the unit tests * fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing * change: added unit test for verifying yaml safe_load method * change: addressed PR comments for SageMaker Config * change: Sagemaker Config - minor clarification * change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig * change: Refactoring session.py and added additional schema validation for ValidationProfiles * update: expand one unit test * update: new integ test for cross context injection * change: remove unwanted method and replace it with a different method for config injection * fix: Address documentation errors and removed unnecessary properties and setters * fix: moving certain config file helper methods to utils.py * change: Add a separate helper to merge list of objects * fix: Documentation updates for SageMakerConfig * fix: bubble up exceptions from S3 while fetching the Config * fix: Added additional test cases for config helper methods. Also made minor documentation updates. * fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config * fix: Replace SageMakerConfig class with just method invocations * fix: fix broken unit tests due to refactoring * fix: bug where a user-provided sagemaker_config wasnt set * change: rename fetch_sagemaker_config to load_sagemaker_config * fix: update Schema to match exactly with APIs * add documentation for default configuration support * fix linting errors * fix link lint * fix lint --------- Co-authored-by: Balaji Sankar <[email protected]> Co-authored-by: Balaji Sankar <[email protected]> Co-authored-by: Ruban Hussain <[email protected]> Co-authored-by: Ivy Bazan <[email protected]>
doddaspk-amzn
pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
* feature: Added Config parser for SageMaker Python SDK (aws#840) Co-authored-by: Balaji Sankar <[email protected]> * intelligent defaults - tags and encryption (aws#842) * feature: sagemaker config - support tags for all APIs * feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs --------- Co-authored-by: Ruban Hussain <[email protected]> * intelligent defaults - custom parameters and small fixes (aws#845) * fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects * feature: sagemaker-config - support for custom parameters in config schema --------- Co-authored-by: Ruban Hussain <[email protected]> * feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846) Co-authored-by: Balaji Sankar <[email protected]> * fix: Make Key, Value as required fields for each "Tags" entry in the config file. * fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849) Co-authored-by: Balaji Sankar <[email protected]> * Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850) Co-authored-by: Balaji Sankar <[email protected]> * fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring * change: Sagemaker Config - improved readability of print statements and simplified its code * fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements * fix: Sagemaker Config - add function description * fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests * change: new integ test for sagemaker_config * fix: Sagemaker Config - fleshed out unit tests and fixed bugs * fix: Sagemaker Config - Removed hard coded config values in the unit tests * fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing * change: added unit test for verifying yaml safe_load method * change: addressed PR comments for SageMaker Config * change: Sagemaker Config - minor clarification * change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig * change: Refactoring session.py and added additional schema validation for ValidationProfiles * update: expand one unit test * update: new integ test for cross context injection * change: remove unwanted method and replace it with a different method for config injection * fix: Address documentation errors and removed unnecessary properties and setters * fix: moving certain config file helper methods to utils.py * change: Add a separate helper to merge list of objects * fix: Documentation updates for SageMakerConfig * fix: bubble up exceptions from S3 while fetching the Config * fix: Added additional test cases for config helper methods. Also made minor documentation updates. * fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config * fix: Replace SageMakerConfig class with just method invocations * fix: fix broken unit tests due to refactoring * fix: bug where a user-provided sagemaker_config wasnt set * change: rename fetch_sagemaker_config to load_sagemaker_config * fix: update Schema to match exactly with APIs * add documentation for default configuration support * fix linting errors * fix link lint * fix lint --------- Co-authored-by: Balaji Sankar <[email protected]> Co-authored-by: Balaji Sankar <[email protected]> Co-authored-by: Ruban Hussain <[email protected]> Co-authored-by: Ivy Bazan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.