Skip to content

fix: update feature store offline s3 path used in tests #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2023
Merged

fix: update feature store offline s3 path used in tests #3752

merged 4 commits into from
Mar 29, 2023

Conversation

psnilesh
Copy link
Contributor

@psnilesh psnilesh commented Mar 24, 2023 •
edited
Loading

Issue

None

Description

cleanup_offline_store method in test_feature_group.py is using table_name to construct offline store S3 URI when it should have used resolvedOutputS3URI. This used to work, but the service team is planning a change to table name so I'm updating the tests to keep the CI / CD pipeline running.

Testing done:
Ran both modified integration tests against personal account using tox,

tox -- -k 'test_create_dataset_with_feature_group_base'

Merge Checklist

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@psnilesh psnilesh requested a review from a team as a code owner March 24, 2023 05:32
@psnilesh psnilesh requested review from trajanikant and removed request for a team March 24, 2023 05:32
knikure
knikure reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4f37c21
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 4f37c21
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4f37c21
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4f37c21
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #3752 (200136f) into master (07dd8ba) will decrease coverage by 0.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3752      +/-   ##
==========================================
- Coverage   89.85%   89.08%   -0.77%     
==========================================
  Files         984      231     -753     
  Lines       92388    22853   -69535     
==========================================
- Hits        83012    20358   -62654     
+ Misses       9376     2495    -6881

see 1215 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4f37c21
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@psnilesh
Copy link
Contributor Author

psnilesh commented Mar 24, 2023 •
edited
Loading

Can we retry the failed tests ? I took a quick peek at the logs and they don't seem to be related to feature group module.

claytonparnell
claytonparnell reviewed Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@claytonparnell claytonparnell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 200136f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 200136f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 200136f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 200136f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 200136f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 200136f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 200136f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 200136f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 200136f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@claytonparnell claytonparnell merged commit 3fed846 into aws:master Mar 29, 2023
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Apr 3, 2023
@psnilesh @evakravi
fix: update feature store offline s3 path used in tests (aws#3752)
0ff1754 
* fix: use resolvedOutputS3Uri to clean up feature group offline store

* chore: run black-format on feature store integ tests

---------

Co-authored-by: Nilesh <[email protected]>
doddaspk-amzn pushed a commit to doddaspk-amzn/sagemaker-python-sdk that referenced this pull request Apr 6, 2023
@psnilesh @doddaspk-amzn
fix: update feature store offline s3 path used in tests (aws#3752)
bc32623 
* fix: use resolvedOutputS3Uri to clean up feature group offline store

* chore: run black-format on feature store integ tests

---------

Co-authored-by: Nilesh <[email protected]>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@psnilesh
fix: update feature store offline s3 path used in tests (aws#3752)
0b49e75 
* fix: use resolvedOutputS3Uri to clean up feature group offline store

* chore: run black-format on feature store integ tests

---------

Co-authored-by: Nilesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claytonparnell claytonparnell claytonparnell left review comments

@knikure knikure knikure left review comments

@trajanikant trajanikant Awaiting requested review from trajanikant trajanikant is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@psnilesh @sagemaker-bot @codecov-commenter @claytonparnell @knikure