fix: always delete temporary directory even during exception #3751

evakravi · 2023-03-23T16:57:25Z

Issue #, if available:
fix: always delete temporary directory even during exception

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-03-23T17:03:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 29beb96
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T17:54:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 58038a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T18:01:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 58038a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T18:04:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 58038a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T18:09:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 58038a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-03-23T18:09:08Z

Codecov Report

Merging #3751 (5215315) into master (ddf6242) will decrease coverage by 0.77%.
The diff coverage is 85.86%.

@@            Coverage Diff             @@
##           master    #3751      +/-   ##
==========================================
- Coverage   90.21%   89.44%   -0.77%     
==========================================
  Files         996      234     -762     
  Lines       94508    23459   -71049     
==========================================
- Hits        85256    20982   -64274     
+ Misses       9252     2477    -6775

Impacted Files	Coverage Δ
src/sagemaker/tuner.py	`90.67% <0.00%> (ø)`
src/sagemaker/hyperparameters.py	`80.95% <50.00%> (ø)`
src/sagemaker/jumpstart/exceptions.py	`82.75% <66.66%> (ø)`
src/sagemaker/jumpstart/artifacts.py	`90.19% <85.71%> (ø)`
src/sagemaker/fw_utils.py	`90.80% <87.50%> (ø)`
src/sagemaker/instance_types.py	`89.47% <89.47%> (ø)`
src/sagemaker/debugger/profiler_config.py	`96.77% <100.00%> (ø)`
src/sagemaker/deprecations.py	`100.00% <100.00%> (ø)`
src/sagemaker/environment_variables.py	`90.90% <100.00%> (ø)`
src/sagemaker/jumpstart/types.py	`95.18% <100.00%> (ø)`
... and 3 more

... and 1217 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-03-23T18:19:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 58038a9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run slow-tests, unit-tests

sagemaker-bot · 2023-03-23T18:33:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 58038a9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T20:42:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f0ae685
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T21:22:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f0ae685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T21:24:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f0ae685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T21:28:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f0ae685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T21:32:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f0ae685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T23:51:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f0ae685
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T17:39:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fb4c4b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T17:47:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fb4c4b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T17:47:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: fb4c4b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T17:48:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fb4c4b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T19:44:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fb4c4b7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T20:43:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8ff6ff5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T21:16:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8ff6ff5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T21:21:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8ff6ff5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T21:25:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8ff6ff5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T21:26:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8ff6ff5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-28T15:48:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8ff6ff5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-28T17:52:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8ff6ff5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-03T15:09:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5215315
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-03T15:28:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5215315
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-03T15:36:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5215315
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-03T15:42:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5215315
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-03T17:35:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5215315
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi requested a review from a team as a code owner March 23, 2023 16:57

evakravi requested review from knikure and removed request for a team March 23, 2023 16:57

knikure self-assigned this Mar 23, 2023

fix: always delete temporary directory even during exception

58038a9

knikure force-pushed the fix/tmpdir-always-delete branch from 29beb96 to 58038a9 Compare March 23, 2023 17:13

claytonparnell reviewed Mar 23, 2023

View reviewed changes

Merge branch 'master' into fix/tmpdir-always-delete

f0ae685

Merge branch 'master' into fix/tmpdir-always-delete

fb4c4b7

Merge branch 'master' into fix/tmpdir-always-delete

8ff6ff5

Merge branch 'master' into fix/tmpdir-always-delete

5215315

knikure approved these changes Apr 3, 2023

View reviewed changes

JGuinegagne approved these changes Apr 3, 2023

View reviewed changes

knikure merged commit b5e5480 into aws:master Apr 3, 2023

doddaspk-amzn pushed a commit to doddaspk-amzn/sagemaker-python-sdk that referenced this pull request Apr 6, 2023

fix: always delete temporary directory even during exception (aws#3751)

13ee36e

fix: always delete temporary directory even during exception #3751

fix: always delete temporary directory even during exception #3751

Uh oh!

Conversation

evakravi commented Mar 23, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

claytonparnell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 24, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 23, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading