Fixes the completion_criteria_config dict in the to_input_req method #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradsemsch
requested review from
mufaddal-rohawala
and removed request for
a team
trajanikant
force-pushed
the
fix/3743-fix-tuning-job-completion-criteria-config
branch
from
cfe9ec7 to
46dec16
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trajanikant
force-pushed
the
fix/3743-fix-tuning-job-completion-criteria-config
branch
from
46dec16 to
4261da3
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trajanikant
force-pushed
the
fix/3743-fix-tuning-job-completion-criteria-config
branch
from
4261da3 to
f31b613
Compare
evakravi
pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
…ws#3744) Co-authored-by: Konrad Semsch <[email protected]>
doddaspk-amzn
pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
…ws#3744) Co-authored-by: Konrad Semsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3743
Description of changes: adds missing dictionary keys in the
to_input_reqmethod of theTuningJobCompletionCriteriaConfigclassTesting done: interactively in jupyter notebook and by launching an HPO job successfully
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.