Deprecation warning for framework profiling for TF 2.12 and on, PT 2.0 and on #3728

mariumof · 2023-03-17T18:31:06Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-03-17T18:35:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fae110b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-17T19:02:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4b6da98
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-17T19:38:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2bd0a5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-17T19:44:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f2bd0a5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-17T20:24:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f2bd0a5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-17T20:27:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f2bd0a5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-17T20:27:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f2bd0a5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-19T15:08:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2d6018b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-03-19T15:09:20Z

Codecov Report

Merging #3728 (e51c642) into master (9946d67) will decrease coverage by 0.77%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master    #3728      +/-   ##
==========================================
- Coverage   89.85%   89.08%   -0.77%     
==========================================
  Files         984      231     -753     
  Lines       92384    22879   -69505     
==========================================
- Hits        83008    20382   -62626     
+ Misses       9376     2497    -6879

Impacted Files	Coverage Δ
src/sagemaker/fw_utils.py	`90.80% <87.50%> (ø)`
src/sagemaker/debugger/profiler_config.py	`96.77% <100.00%> (ø)`
src/sagemaker/deprecations.py	`100.00% <100.00%> (ø)`
src/sagemaker/pytorch/estimator.py	`92.47% <100.00%> (ø)`
src/sagemaker/tensorflow/estimator.py	`92.30% <100.00%> (ø)`

... and 1210 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-03-19T15:12:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2d6018b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-19T15:15:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2d6018b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-19T15:15:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2d6018b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-19T15:35:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2d6018b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

olegtalalov

I wonder if you could add an informative PR name and PR description.

src/sagemaker/debugger/profiler_config.py

src/sagemaker/fw_utils.py

tests/unit/test_profiler_config.py

sagemaker-bot · 2023-03-22T22:35:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b5d5f6b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T22:38:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b5d5f6b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T00:40:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b5d5f6b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T19:51:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c7d8ba8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T20:39:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c7d8ba8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T20:40:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c7d8ba8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T20:43:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c7d8ba8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-23T22:48:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c7d8ba8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T13:35:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e51c642
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T14:05:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e51c642
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T14:18:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e51c642
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T14:22:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e51c642
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-24T14:24:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e51c642
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2023-03-29T21:48:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e51c642
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T16:10:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e6fdd44
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T16:42:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e6fdd44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T16:58:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e6fdd44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T17:02:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e6fdd44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T17:22:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e6fdd44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run unit-tests

sagemaker-bot · 2023-03-30T19:17:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e6fdd44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…on, PT 2.0 and on (aws#3728) * fix: added framework profiling version deprecation warning * fix: add deprecation warning * fix: add deprecation warning * Deprecation warning * Deprecation * fix: added framework profiling version deprecation warning * fix: add deprecation warning * fix: add deprecation warning * Deprecation warning * Deprecation * Deprecation warnings for Tf2.11 and PT 2.0 * Deprecation warning for TF2.12 ant PT 2.0 for framework profiling

mariumof added 3 commits March 17, 2023 15:26

fix: added framework profiling version deprecation warning

d2eda9c

fix: add deprecation warning

ad0fdd8

fix: add deprecation warning

fae110b

mariumof requested a review from a team as a code owner March 17, 2023 18:31

mariumof requested review from mufaddal-rohawala and removed request for a team March 17, 2023 18:31

Deprecation warning

4b6da98

Deprecation

f2bd0a5

olegtalalov suggested changes Mar 20, 2023

View reviewed changes

src/sagemaker/debugger/profiler_config.py Show resolved Hide resolved

src/sagemaker/fw_utils.py Outdated Show resolved Hide resolved

tests/unit/test_profiler_config.py Outdated Show resolved Hide resolved

tests/unit/test_profiler_config.py Outdated Show resolved Hide resolved

mchoi8739 mentioned this pull request Mar 20, 2023

documentation: Update SageMaker Debugger doc #3723

Merged

9 tasks

mariumof added 5 commits March 20, 2023 12:48

fix: added framework profiling version deprecation warning

50a6da2

fix: add deprecation warning

fc081c7

fix: add deprecation warning

315e261

Deprecation warning

37a3a59

Deprecation

10201c5

knikure force-pushed the deprecation branch from 2d6018b to 10201c5 Compare March 20, 2023 19:48

Merge branch 'master' into deprecation

30462b2

mariumof requested a review from mufaddal-rohawala March 23, 2023 13:13

Merge branch 'master' into deprecation

c7d8ba8

Merge branch 'master' into deprecation

e51c642

mufaddal-rohawala approved these changes Mar 29, 2023

View reviewed changes

mufaddal-rohawala reviewed Mar 29, 2023

View reviewed changes

Merge branch 'master' into deprecation

e6fdd44

claytonparnell reviewed Mar 30, 2023

View reviewed changes

claytonparnell merged commit ce5f8a6 into aws:master Mar 30, 2023

Deprecation warning for framework profiling for TF 2.12 and on, PT 2.0 and on #3728

Deprecation warning for framework profiling for TF 2.12 and on, PT 2.0 and on #3728

Uh oh!

Conversation

mariumof commented Mar 17, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 19, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Mar 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 19, 2023

AWS CodeBuild CI Report

Uh oh!

olegtalalov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 23, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 19, 2023 •

edited

Loading