Adding support for 1P Algorithms in ZAZ, ZRH, HYD, MEL #3724

secastillo · 2023-03-16T02:49:34Z

Description of changes:
Adding new region (ZAZ, ZRH, HYD, MEL) accounts

Testing done:
tox -e py39 -- tests/unit/test_amazon_estimator.py
tox -e black-format
tox -e py39 -- tests/unit/sagemaker/image_uris/test_xgboost.py
tox -e py39 -- tests/unit/sagemaker/image_uris/test_sklearn.py
tox -e py39 -- tests/unit/sagemaker/image_uris/test_algos.py

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-03-16T03:24:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dd336c7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T03:37:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dd336c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T03:45:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dd336c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-03-16T03:57:57Z

Codecov Report

Merging #3724 (db8cdd0) into master (0d7a826) will decrease coverage by 0.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3724      +/-   ##
==========================================
- Coverage   89.84%   89.06%   -0.78%     
==========================================
  Files         984      231     -753     
  Lines       92312    22834   -69478     
==========================================
- Hits        82936    20338   -62598     
+ Misses       9376     2496    -6880

see 1215 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-03-16T03:58:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: dd336c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T05:50:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dd336c7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T16:05:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 10ac085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T16:16:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 10ac085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T16:22:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 10ac085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T16:23:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 10ac085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T16:31:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 10ac085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run slow-tests, pr

sagemaker-bot · 2023-03-16T16:52:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 10ac085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T17:03:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 10ac085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T17:23:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 10ac085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T16:34:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d92fdc6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T16:37:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T16:38:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d92fdc6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T16:40:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d92fdc6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T18:48:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T22:07:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T23:07:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-20T23:28:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T00:14:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T01:45:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T02:31:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d92fdc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T15:09:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: db8cdd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T15:11:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: db8cdd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T15:56:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: db8cdd0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T16:00:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: db8cdd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T16:01:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: db8cdd0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T16:21:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: db8cdd0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T18:34:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: db8cdd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T19:55:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: db8cdd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T20:24:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: db8cdd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…3724) * feature: Adding support for 1P Algorithms in ZAZ and ZRH * feature: Adding support for 1P Algorithms in HYD * feature: Adding support for 1P Algorithms in MEL * feature: Adding new regions to new SKLearn and XGBoost versions * minor: Formatting cleanup * feature: Adding support for 1P Algorithms in ZAZ and ZRH * feature: Adding support for 1P Algorithms in HYD * feature: Adding support for 1P Algorithms in MEL * feature: Adding new regions to new SKLearn and XGBoost versions * minor: Formatting cleanup * Adding new region accounts to DeepAR

secastillo added 3 commits March 15, 2023 19:32

feature: Adding support for 1P Algorithms in ZAZ and ZRH

a09322d

feature: Adding support for 1P Algorithms in HYD

a2ac391

feature: Adding support for 1P Algorithms in MEL

dd336c7

secastillo added 2 commits March 16, 2023 11:19

feature: Adding new regions to new SKLearn and XGBoost versions

0828818

minor: Formatting cleanup

10ac085

secastillo requested review from malav-shastri and claytonparnell March 16, 2023 16:18

secastillo marked this pull request as ready for review March 16, 2023 16:19

secastillo requested a review from a team as a code owner March 16, 2023 16:19

claytonparnell self-assigned this Mar 16, 2023

claytonparnell reviewed Mar 16, 2023

View reviewed changes

secastillo requested review from claytonparnell and a team and removed request for malav-shastri March 16, 2023 16:46

malav-shastri approved these changes Mar 17, 2023

View reviewed changes

feature: Adding support for 1P Algorithms in ZAZ and ZRH

187d3dd

secastillo added 4 commits March 20, 2023 11:41

feature: Adding support for 1P Algorithms in HYD

34712c5

feature: Adding support for 1P Algorithms in MEL

72fe910

feature: Adding new regions to new SKLearn and XGBoost versions

450e40f

minor: Formatting cleanup

d92fdc6

claytonparnell force-pushed the new_regions branch from 10ac085 to d92fdc6 Compare March 20, 2023 15:44

secastillo added 2 commits March 21, 2023 10:55

Adding new region accounts to DeepAR

6da63e7

Merge remote-tracking branch 'origin/new_regions' into new_regions

db8cdd0

claytonparnell approved these changes Mar 21, 2023

View reviewed changes

claytonparnell merged commit e22ccb4 into aws:master Mar 21, 2023

Adding support for 1P Algorithms in ZAZ, ZRH, HYD, MEL #3724

Adding support for 1P Algorithms in ZAZ, ZRH, HYD, MEL #3724

Conversation

secastillo commented Mar 16, 2023

Merge Checklist

General

Tests

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

codecov-commenter commented Mar 16, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

claytonparnell left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 20, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

codecov-commenter commented Mar 16, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading