-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feature: Combined inference and training script artifact #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knikure
merged 14 commits into
aws:master
from
evakravi:feat/inference-plus-training-script
Apr 4, 2023
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
edcfe67
feat: combined inference + training script artifact
evakravi c09435f
fix: jumpstart unit tests
evakravi 80b0464
chore: always include training script if available
evakravi 72cc8ea
Merge branch 'master' into feat/inference-plus-training-script
evakravi 26ea2eb
Merge branch 'master' into feat/inference-plus-training-script
evakravi 4ec318a
Merge branch 'master' into feat/inference-plus-training-script
evakravi f66869b
Merge branch 'master' into feat/inference-plus-training-script
evakravi 6374d62
Merge branch 'master' into feat/inference-plus-training-script
evakravi 726c751
Merge branch 'master' into feat/inference-plus-training-script
evakravi 03d14f7
Merge branch 'master' into feat/inference-plus-training-script
evakravi 4f345db
Merge remote-tracking branch 'origin' into feat/inference-plus-traini…
evakravi 0841f13
Merge branch 'master' into feat/inference-plus-training-script
evakravi 8e461ca
fix: script scope should be training
evakravi 35db230
chore: remove extra line
evakravi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
tests/unit/sagemaker/script_uris/jumpstart/test_combined_script_artifact.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You | ||
# may not use this file except in compliance with the License. A copy of | ||
# the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is | ||
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific | ||
# language governing permissions and limitations under the License. | ||
from __future__ import absolute_import | ||
|
||
from mock.mock import patch | ||
|
||
from sagemaker import script_uris | ||
|
||
from tests.unit.sagemaker.jumpstart.utils import get_special_model_spec | ||
|
||
|
||
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs") | ||
def test_jumpstart_combined_artifacts(patched_get_model_specs): | ||
|
||
patched_get_model_specs.side_effect = get_special_model_spec | ||
|
||
model_id_combined_script_artifact = "mock-model-training-prepacked-script-key" | ||
|
||
uri = script_uris.retrieve( | ||
region="us-west-2", | ||
script_scope="inference", | ||
model_id=model_id_combined_script_artifact, | ||
model_version="*", | ||
) | ||
assert ( | ||
uri == "s3://jumpstart-cache-prod-us-west-2/some/key/to/" | ||
"training_prepacked_script_key.tar.gz" | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: shouldn't there be a way to access the uncombined model artifact?
Could you please align with @whittech1 on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided that there is no harm in including the script with the model artifact, even if someone only wants the model artifact. Most of the combined tarball is the model artifact, so it doesn't make a huge difference in terms of storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The risk is that there are extra files left over from the combined model artifact in the
code
dir when a user tries to override the script. In the worst case, it could make the new combined script crash. Maybe we should sleep on this.