Skip to content

Revert "feature: Decouple model.right_size() from model registry" #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

claytonparnell
Copy link
Collaborator

Reverts #3688
This PR introduced the test integ/test_inference_recommender.py::default_right_sized_unregistered_base_model which initializes a Model() missing the positional argument image_uri, so the test fails with TypeError every time.

@claytonparnell claytonparnell requested a review from a team as a code owner March 7, 2023 22:25
@claytonparnell claytonparnell requested review from navinsoni and removed request for a team March 7, 2023 22:25
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 427f60c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 427f60c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 427f60c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 427f60c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 427f60c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Merging #3700 (427f60c) into master (67dc885) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3700      +/-   ##
==========================================
- Coverage   89.79%   89.01%   -0.79%     
==========================================
  Files         980      230     -750     
  Lines       92208    22797   -69411     
==========================================
- Hits        82797    20292   -62505     
+ Misses       9411     2505    -6906     
Impacted Files Coverage Δ
src/sagemaker/session.py 75.39% <ø> (ø)
...ference_recommender/inference_recommender_mixin.py 92.10% <100.00%> (ø)
...hon3.10/site-packages/sagemaker/hyperparameters.py
...hon3.7/site-packages/sagemaker/workflow/airflow.py
.../site-packages/sagemaker/experiments/experiment.py
...0/site-packages/sagemaker/huggingface/estimator.py
...ython3.8/site-packages/sagemaker/workflow/retry.py
...on3.8/site-packages/sagemaker/chainer/estimator.py
...3.8/site-packages/sagemaker/lineage/association.py
...n3.8/site-packages/sagemaker/experiments/_utils.py
... and 1202 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants