feat: jumpstart instance types #3686

evakravi · 2023-02-28T18:48:50Z

Issue #, if available:

Description of changes:
New utility has been created for retrieving default and supported instance types for jumpstart models.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-02-28T19:35:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c28134a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-02-28T19:36:57Z

Codecov Report

Merging #3686 (516da5b) into master (ddf6242) will decrease coverage by 0.77%.
The diff coverage is 85.39%.

@@            Coverage Diff             @@
##           master    #3686      +/-   ##
==========================================
- Coverage   90.21%   89.44%   -0.77%     
==========================================
  Files         996      234     -762     
  Lines       94508    23458   -71050     
==========================================
- Hits        85256    20981   -64275     
+ Misses       9252     2477    -6775

Impacted Files	Coverage Δ
src/sagemaker/tuner.py	`90.67% <0.00%> (ø)`
src/sagemaker/hyperparameters.py	`80.95% <50.00%> (ø)`
src/sagemaker/jumpstart/exceptions.py	`82.75% <66.66%> (ø)`
src/sagemaker/jumpstart/artifacts.py	`90.19% <85.71%> (ø)`
src/sagemaker/fw_utils.py	`90.80% <87.50%> (ø)`
src/sagemaker/instance_types.py	`89.47% <89.47%> (ø)`
src/sagemaker/debugger/profiler_config.py	`96.77% <100.00%> (ø)`
src/sagemaker/deprecations.py	`100.00% <100.00%> (ø)`
src/sagemaker/environment_variables.py	`90.90% <100.00%> (ø)`
src/sagemaker/jumpstart/types.py	`95.18% <100.00%> (ø)`
... and 2 more

... and 1218 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-02-28T19:40:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c28134a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T19:42:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c28134a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T19:43:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c28134a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T21:41:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c28134a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JGuinegagne · 2023-03-02T14:53:08Z

src/sagemaker/instance_types.py

+            (exception not raised). False if these models should raise an exception.
+            (Default: False).
+    Returns:
+        dict: The default instance type to use for the model.


why dict? Shouldn't it be str?

JGuinegagne · 2023-03-02T14:53:34Z

src/sagemaker/instance_types.py

+    scope=None,
+    tolerate_vulnerable_model: bool = False,
+    tolerate_deprecated_model: bool = False,
+) -> Optional[str]:


question: why is the return type Optional?

If a model is not supported in a region because no instances are available, I would vote to raise an exception with an error message asking customers to use a different AWS region.

JGuinegagne · 2023-03-02T14:54:52Z

src/sagemaker/instance_types.py

+    scope=None,
+    tolerate_vulnerable_model: bool = False,
+    tolerate_deprecated_model: bool = False,
+) -> Optional[List[str]]:


same question please. If no instance is available in a region, I would vote for either returning an empty list or raising an error.

JGuinegagne · 2023-03-02T14:55:59Z

src/sagemaker/instance_types.py

+            (exception not raised). False if these models should raise an exception.
+            (Default: False).
+    Returns:
+        dict: The supported instance types to use for the model.


revise docstring please, this utility returns a list.

JGuinegagne · 2023-03-02T14:57:26Z

src/sagemaker/jumpstart/artifacts.py

+            specifications should be tolerated (exception not raised). If False, raises
+            an exception if the version of the model is deprecated. (Default: False).
+    Returns:
+        list: the default instance type to use for the model or None.


incorrect docstring.

add a raise section please

sagemaker-bot · 2023-03-06T14:52:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 37ad9e4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T15:20:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 37ad9e4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T15:33:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 37ad9e4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T15:39:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 37ad9e4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T15:42:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 37ad9e4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T17:51:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1da64e7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T18:02:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1da64e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T18:06:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1da64e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T18:10:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1da64e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T18:19:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1da64e7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T20:33:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 975def8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-16T20:45:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 975def8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T12:37:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f9e2fb4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T12:43:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f9e2fb4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T14:43:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f9e2fb4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T17:56:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9a46fcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T18:12:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9a46fcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T18:17:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9a46fcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T18:22:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9a46fcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T18:22:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9a46fcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T19:32:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d3c77aa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T19:34:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d3c77aa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T19:35:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d3c77aa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T19:40:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d3c77aa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T21:42:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d3c77aa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-29T22:44:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d3c77aa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-03-30T20:13:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 516da5b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T20:31:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 516da5b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T20:36:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 516da5b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T20:42:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 516da5b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-30T22:42:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 516da5b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-03-31T03:40:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 516da5b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feat: jumpstart instance types

c28134a

evakravi requested a review from a team as a code owner February 28, 2023 18:48

evakravi requested review from trajanikant and removed request for a team February 28, 2023 18:48

JGuinegagne requested changes Mar 2, 2023

View reviewed changes

Merge branch 'master' into feat/jumpstart-instance-types

37ad9e4

knikure assigned trajanikant Mar 13, 2023

evakravi marked this pull request as draft March 16, 2023 13:54

chore: raise exception when no instances available in region

7baec98

evakravi force-pushed the feat/jumpstart-instance-types branch from ecb5d76 to 7baec98 Compare March 16, 2023 17:05

Merge remote-tracking branch 'origin' into feat/jumpstart-instance-types

1da64e7

chore: update integ test

975def8

Merge branch 'master' into feat/jumpstart-instance-types

9a46fcb

Merge branch 'master' into feat/jumpstart-instance-types

d3c77aa

trajanikant reviewed Mar 30, 2023

View reviewed changes

claytonparnell approved these changes Mar 30, 2023

View reviewed changes

Merge branch 'master' into feat/jumpstart-instance-types

516da5b

trajanikant reviewed Mar 30, 2023

View reviewed changes

trajanikant reviewed Mar 31, 2023

View reviewed changes

trajanikant merged commit d81a305 into aws:master Mar 31, 2023

evakravi added a commit to evakravi/sagemaker-python-sdk that referenced this pull request Apr 3, 2023

feat: jumpstart instance types (aws#3686)

6409579

doddaspk-amzn pushed a commit to doddaspk-amzn/sagemaker-python-sdk that referenced this pull request Apr 6, 2023

feat: jumpstart instance types (aws#3686)

ad4efb1

feat: jumpstart instance types #3686

feat: jumpstart instance types #3686

Conversation

evakravi commented Feb 28, 2023

Merge Checklist

General

Tests

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

codecov-commenter commented Feb 28, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

JGuinegagne Mar 2, 2023

Choose a reason for hiding this comment

JGuinegagne Mar 2, 2023

Choose a reason for hiding this comment

JGuinegagne Mar 2, 2023

Choose a reason for hiding this comment

JGuinegagne Mar 2, 2023

Choose a reason for hiding this comment

JGuinegagne Mar 2, 2023

Choose a reason for hiding this comment

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 29, 2023

codecov-commenter commented Feb 28, 2023 •

edited

Loading