Skip to content

change: Add djl 0.21.0 dlc images #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

change: Add djl 0.21.0 dlc images #3685

merged 1 commit into from
Mar 3, 2023

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Feb 27, 2023 •
edited
Loading

Issue #, if available:
N/A

Description of changes:
Adds the latest container release to image_uris for djl-deepspeed.

Testing done: Updated unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siddvenk siddvenk requested a review from a team as a code owner February 27, 2023 21:24
@siddvenk siddvenk requested review from navinsoni and removed request for a team February 27, 2023 21:24
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023 •
edited
Loading

Codecov Report

Merging #3685 (b36e7c2) into master (48a90a5) will decrease coverage by 0.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3685      +/-   ##
==========================================
- Coverage   89.73%   88.95%   -0.79%     
==========================================
  Files         968      227     -741     
  Lines       91056    22520   -68536     
==========================================
- Hits        81712    20033   -61679     
+ Misses       9344     2487    -6857
Impacted Files Coverage Δ
...ackages/sagemaker/cli/compatibility/v2/__init__.py
...ib/python3.10/site-packages/sagemaker/analytics.py
...7/lib/python3.7/site-packages/sagemaker/clarify.py
.../python3.8/site-packages/sagemaker/rl/estimator.py
...packages/sagemaker/workflow/execution_variables.py
...python3.7/site-packages/sagemaker/lambda_helper.py
...on3.8/site-packages/sagemaker/debugger/debugger.py
...on3.8/site-packages/sagemaker/jumpstart/filters.py
...on3.10/site-packages/sagemaker/local/exceptions.py
....7/site-packages/sagemaker/jumpstart/parameters.py
... and 1185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b36e7c2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b36e7c2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

frankfliu
frankfliu reviewed Feb 28, 2023
View reviewed changes
Copy link

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to update version in : src/sagemaker/djl_inference/model.py and .rst file

@siddvenk
Copy link
Contributor Author

You might want to update version in : src/sagemaker/djl_inference/model.py and .rst file

Yes, working on that update now. Will call out in that PR to wait for this one to be merged first.

@siddvenk siddvenk mentioned this pull request Feb 28, 2023
Merged
9 tasks
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b36e7c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@siddvenk
Copy link
Contributor Author

siddvenk commented Mar 1, 2023

@navinsoni it looks like the slow-tests are failing for reasons unrelated to this PR (some issue with the airflow module).

Have these issues been fixed and pushed to the master branch? I can rebase and try again if so.

If not, are we ok to merge this PR? I have 2 approvals from my team.

navinsoni
navinsoni reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@navinsoni navinsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b36e7c2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@siddvenk
Copy link
Contributor Author

siddvenk commented Mar 3, 2023

Looks like the slow tests are still failing due to reasons unrelated to this change. Are we ok to merge this change?

@navinsoni navinsoni merged commit 849ed29 into aws:master Mar 3, 2023
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@siddvenk @JoseJuan98
change: Add djl 0.21.0 dlc images (aws#3685)
1cb2722
@siddvenk siddvenk deleted the djl-image-uris branch March 9, 2023 21:34
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@siddvenk
change: Add djl 0.21.0 dlc images (aws#3685)
cf0f569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navinsoni navinsoni navinsoni approved these changes

@lanking520 lanking520 lanking520 approved these changes

@frankfliu frankfliu frankfliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@siddvenk @sagemaker-bot @codecov-commenter @navinsoni @lanking520 @frankfliu