Add volume KMS key to transformer #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the optional VolumeKmsKeyId parameter of CreateTuningJob
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 93.24% 93.25% +<.01%
==========================================
Files 52 52
Lines 3658 3663 +5
==========================================
+ Hits 3411 3416 +5
Misses 247 247
Continue to review full report at Codecov.
|
nadiaya
suggested changes
Aug 29, 2018
CHANGELOG.rst
Outdated
| @@ -11,6 +11,7 @@ CHANGELOG | |||
| ===== | |||
|
|
|||
| * feature: add support for TensorFlow 1.9 | |||
| * enhancement: Add support for volume KMS key to Transformer | |||
There was a problem hiding this comment.
Can you move it to the next section (1.9.3dev I believe)? This one already was released
There was a problem hiding this comment.
Fixed, also updated transformer integ tests to include the volume KMS key
added 2 commits
August 29, 2018 13:44
This also adds volume KMS key to Estimator.transformer()
nadiaya
previously approved these changes
Aug 30, 2018
nadiaya
approved these changes
Sep 27, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
* Add volume KMS key to transformer This adds support for the optional VolumeKmsKeyId parameter of CreateTuningJob * Fix changelog and add integ test This also adds volume KMS key to Estimator.transformer() * Fixing flake errors * Fix resource config preparation for volume kms key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the optional VolumeKmsKeyId parameter of CreateTransformJob
Issue #, if available: N/A
Description of changes: This change adds support for specifying a volume KMS key, which is used to encrypt the volume attached to the ML compute instance for a transform job.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.