Skip to content

fix: Unable to attach estimator to training job when KeepAlivePeriodInSeconds specified #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
May 2, 2023
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
014b343
fix: Unable to attach estimator to training job when KeepAlivePeriodI…
TheOnly92 Feb 22, 2023
23f899d
Merge branch 'master' into patch-1
TheOnly92 Feb 24, 2023
15bfbbf
Merge branch 'master' into patch-1
TheOnly92 Feb 28, 2023
089fa65
Merge branch 'master' into patch-1
TheOnly92 Mar 2, 2023
6e9a072
Merge branch 'master' into patch-1
TheOnly92 Mar 3, 2023
bf6396a
Merge branch 'master' into patch-1
TheOnly92 Mar 6, 2023
796b4ef
Merge branch 'master' into patch-1
TheOnly92 Mar 7, 2023
5018123
Merge branch 'master' into patch-1
TheOnly92 Mar 9, 2023
f940f92
Merge branch 'master' into patch-1
TheOnly92 Mar 10, 2023
31116a9
Merge branch 'master' into patch-1
TheOnly92 Mar 13, 2023
4474aaf
Merge branch 'master' into patch-1
TheOnly92 Mar 14, 2023
0ebd4b7
Merge branch 'master' into patch-1
TheOnly92 Mar 15, 2023
25dd97e
Merge branch 'master' into patch-1
TheOnly92 Mar 16, 2023
dfa4a98
Merge branch 'master' into patch-1
TheOnly92 Mar 17, 2023
b8498f5
Merge branch 'master' into patch-1
TheOnly92 Mar 20, 2023
2e0cd42
Merge branch 'master' into patch-1
TheOnly92 Mar 22, 2023
274e1fa
Merge branch 'master' into patch-1
TheOnly92 Mar 23, 2023
6198380
Merge branch 'master' into patch-1
TheOnly92 Mar 24, 2023
ae6e3ff
Merge branch 'master' into patch-1
TheOnly92 Mar 27, 2023
7515bb7
Merge branch 'master' into patch-1
TheOnly92 Mar 28, 2023
c40bb9a
Merge branch 'master' into patch-1
TheOnly92 Mar 31, 2023
9bc695f
Merge branch 'master' into patch-1
TheOnly92 Apr 3, 2023
d3779dd
Merge branch 'master' into patch-1
TheOnly92 Apr 4, 2023
b9d1485
Merge branch 'master' into patch-1
TheOnly92 Apr 7, 2023
3241f61
Merge branch 'master' into patch-1
TheOnly92 Apr 17, 2023
2f05d97
Merge branch 'master' into patch-1
TheOnly92 Apr 18, 2023
4262d2d
Merge branch 'master' into patch-1
TheOnly92 Apr 21, 2023
de08c76
Merge branch 'master' into patch-1
TheOnly92 Apr 25, 2023
ed3ed4a
Merge branch 'master' into patch-1
TheOnly92 Apr 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line number Diff line number Diff line change
Expand Up @@ -1702,7 +1702,7 @@ def _prepare_init_params_from_job_description(cls, job_details, model_channel_na

if "KeepAlivePeriodInSeconds" in job_details["ResourceConfig"]:
init_params["keep_alive_period_in_seconds"] = job_details["ResourceConfig"][
"keepAlivePeriodInSeconds"
"KeepAlivePeriodInSeconds"
]

has_hps = "HyperParameters" in job_details
Expand Down