Skip to content

Support tensorflow 1.9 and bump version to 1.9.2 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Aug 23, 2018

Issue #, if available:

Description of changes:

  1. Support tensorflow 1.9
  2. Bump version to 1.9.2

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

README.rst Outdated
@@ -242,7 +242,7 @@ MXNet SageMaker Estimators

By using MXNet SageMaker ``Estimators``, you can train and host MXNet models on Amazon SageMaker.

Supported versions of MXNet: ``1.2.1``, ``1.1.0``, ``1.0.0``, ``0.12.1``.
Supported versions of MXNet: ``1.2.1``, ``1.1.0``, ``1.0.0``, ``0.12.1``. We recommend to use the latest version and our integration test will only test the latest version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the sentence in a new line after the list of versions and change it to something like "We recommend you use the latest version as that's where we spend most of our development efforts". Maybe @djarpin or @eslesar-aws has a better wording suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"We recommend that you use the latest supported version, because that's where we focus most of our development efforts."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #365   +/-   ##
======================================
  Coverage    92.9%   92.9%           
======================================
  Files          51      51           
  Lines        3567    3567           
======================================
  Hits         3314    3314           
  Misses        253     253
Impacted Files Coverage Δ
src/sagemaker/tensorflow/defaults.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73822c...fc1c7ba. Read the comment docs.

@yangaws yangaws merged commit eefd0c9 into aws:master Aug 23, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Extending SageMaker PyTorch containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants