Skip to content

Create output/data directory in local mode. #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Aug 23, 2018

Create output/data directory expected by sagemaker containers when running in local mode.

aws/amazon-sagemaker-examples#368

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested review from iquintero and laurenyu August 23, 2018 00:53
@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #364 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   93.07%   93.07%   +<.01%     
==========================================
  Files          51       51              
  Lines        3567     3568       +1     
==========================================
+ Hits         3320     3321       +1     
  Misses        247      247
Impacted Files Coverage Δ
src/sagemaker/local/image.py 89.22% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a11a5...b3018b6. Read the comment docs.

laurenyu
laurenyu previously approved these changes Aug 23, 2018
iquintero
iquintero previously approved these changes Aug 28, 2018
@nadiaya nadiaya merged commit d67d9b8 into aws:master Aug 28, 2018
@nadiaya nadiaya deleted the add-output-data branch August 28, 2018 22:21
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
* Create output/data directory expected by sagemaker containers when running in local mode.

* Update changelog.

* Add output/data to directories when running training.
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants