Skip to content

Fix formatting in PyTorch README and remove SDK version in general README #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

laurenyu
Copy link
Contributor

Issue #, if available:
Just some minor things I noticed while reading the READMEs. Also, figured we should remove the explicit SDK version reference because it's so easy for that to become outdated.

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #363 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #363      +/-   ##
=========================================
- Coverage   93.07%   92.9%   -0.17%     
=========================================
  Files          51      51              
  Lines        3567    3567              
=========================================
- Hits         3320    3314       -6     
- Misses        247     253       +6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 87.38% <0%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7634265...c7d3e59. Read the comment docs.

@laurenyu laurenyu merged commit b73822c into aws:master Aug 22, 2018
@laurenyu laurenyu deleted the readme-fixes branch August 22, 2018 23:02
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants