Skip to content

fix: Make test_processor_with_role_as_pipeline_parameter more concrete #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: Make test_processor_with_role_as_pipeline_parameter more concrete #3618

merged 1 commit into from
Feb 1, 2023

Conversation

qidewenwhen
Copy link
Member

@qidewenwhen qidewenwhen commented Jan 27, 2023 •
edited
Loading

Description of changes:
Thanks so much for francescoalongi@ to work on #3605 to fill in a feature gap for us.
This PR3618 attempts to make the related tests more concrete, including:

  • Update the two unit tests added by francescoalongi@ to make it more concrete, i.e.
    • use the PipelineSession rather than the Sagemaker Session, as the new step interface (i.e. step_args = processor.run(...) ) only take effect when PipelineSession is presented.
    • Move these unit tests under workflow's processing step test files, as the test is extended to create a ProcessingStep and a Pipeline based on the processor.
    • Group these two similar tests with parametrize pytest.
    • Verify in the eventual output - pipeline definition level.
  • Update existing integ tests to make sure this change works E2E

Testing done: Integ and unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qidewenwhen qidewenwhen requested a review from a team as a code owner January 27, 2023 21:52
@qidewenwhen qidewenwhen requested review from claytonparnell and removed request for a team January 27, 2023 21:52
@qidewenwhen qidewenwhen force-pushed the master branch 2 times, most recently from b341f29 to a3625ac Compare January 27, 2023 22:01
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: a3625ac
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: a3625ac
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 8bd45d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 8bd45d4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 8bd45d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 8bd45d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #3618 (8bd45d4) into master (1fa2377) will decrease coverage by 0.35%.
The diff coverage is 89.18%.

❗ Current head 8bd45d4 differs from pull request most recent head fa2287f. Consider uploading reports for the commit fa2287f to get more accurate results

@@            Coverage Diff             @@
##           master    #3618      +/-   ##
==========================================
- Coverage   89.17%   88.82%   -0.35%     
==========================================
  Files         204      227      +23     
  Lines       18979    22247    +3268     
==========================================
+ Hits        16924    19762    +2838     
- Misses       2055     2485     +430
Impacted Files Coverage Δ
src/sagemaker/dataset_definition/inputs.py 100.00% <ø> (ø)
src/sagemaker/huggingface/model.py 89.87% <ø> (ø)
src/sagemaker/lineage/_utils.py 100.00% <ø> (+12.50%) ⬆️
...agemaker/model_monitor/clarify_model_monitoring.py 89.84% <ø> (-5.09%) ⬇️
src/sagemaker/model_monitor/dataset_format.py 72.72% <ø> (-2.28%) ⬇️
src/sagemaker/model_monitor/model_monitoring.py 67.43% <ø> (+0.66%) ⬆️
src/sagemaker/model_monitor/monitoring_alert.py 100.00% <ø> (ø)
src/sagemaker/pipeline.py 85.33% <ø> (ø)
src/sagemaker/processing.py 94.25% <ø> (-0.09%) ⬇️
src/sagemaker/pytorch/__init__.py 100.00% <ø> (ø)
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: fa2287f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: fa2287f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: fa2287f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: fa2287f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: fa2287f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: fa2287f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell
claytonparnell reviewed Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@claytonparnell claytonparnell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: fa2287f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: fa2287f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: fa2287f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala merged commit 91a7458 into aws:master Feb 1, 2023
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@qidewenwhen @JoseJuan98
fix: Make test_processor_with_role_as_pipeline_parameter more concrete (
394a329 
aws#3618)
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@qidewenwhen
fix: Make test_processor_with_role_as_pipeline_parameter more concrete (
842a7d9 
aws#3618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navaj0 navaj0 navaj0 approved these changes

@claytonparnell claytonparnell claytonparnell approved these changes

Assignees

@claytonparnell claytonparnell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qidewenwhen @sagemaker-bot @codecov-commenter @navaj0 @claytonparnell @mufaddal-rohawala