Update feature_group.py ingest() description #3615

mwfongAWS · 2023-01-26T22:40:36Z

Updating ingest function description (https://sagemaker.readthedocs.io/en/stable/api/prep_data/feature_store.html#sagemaker.feature_store.feature_group.FeatureGroup.ingest) according to discussion in a thread (https://amzn-aws.slack.com/archives/C02FT61K4BV/p1661876115110819).

Issue #, if available:
https://t.corp.amazon.com/P71244023

Description of changes:
Clarify failed_rows logic and other descriptions according to the discussion here: https://amzn-aws.slack.com/archives/C02FT61K4BV/p1661876115110819

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Updating ingest function description (https://sagemaker.readthedocs.io/en/stable/api/prep_data/feature_store.html#sagemaker.feature_store.feature_group.FeatureGroup.ingest) according to discussion in a thread (https://amzn-aws.slack.com/archives/C02FT61K4BV/p1661876115110819).

claytonparnell

/bot run all

sagemaker-bot · 2023-01-27T18:40:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4d9257d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell · 2023-01-27T18:48:10Z

HI @mwfongAWS - please resolve the following styling errors:
./src/sagemaker/feature_store/feature_group.py:705:92: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:708:87: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:711:88: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:714:91: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:715:91: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:717:1: W293 blank line contains whitespace ./src/sagemaker/feature_store/feature_group.py:718:91: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:719:92: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:721:1: W293 blank line contains whitespace ./src/sagemaker/feature_store/feature_group.py:722:81: W291 trailing whitespace ./src/sagemaker/feature_store/feature_group.py:724:1: W293 blank line contains whitespace
Also please run tox -e black-format, then tox -e flake8, pylint, black-check to ensure all style issues are resolved.

claytonparnell

/bot run local-mode-tests, pr, notebook-tests, slow-tests

sagemaker-bot · 2023-01-27T19:21:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4d9257d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T19:34:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4d9257d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T19:40:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4d9257d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T19:48:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1f8964d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-27T19:49:19Z

Codecov Report

Merging #3615 (1f8964d) into master (1fa2377) will decrease coverage by 0.38%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master    #3615      +/-   ##
==========================================
- Coverage   89.17%   88.79%   -0.38%     
==========================================
  Files         204      227      +23     
  Lines       18979    22174    +3195     
==========================================
+ Hits        16924    19690    +2766     
- Misses       2055     2484     +429

Impacted Files	Coverage Δ
src/sagemaker/dataset_definition/inputs.py	`100.00% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/lineage/_utils.py	`100.00% <ø> (+12.50%)`	⬆️
src/sagemaker/model_monitor/model_monitoring.py	`67.43% <ø> (+0.66%)`	⬆️
src/sagemaker/model_monitor/monitoring_alert.py	`100.00% <ø> (ø)`
src/sagemaker/pipeline.py	`85.33% <ø> (ø)`
src/sagemaker/processing.py	`94.25% <ø> (-0.09%)`	⬇️
src/sagemaker/pytorch/__init__.py	`100.00% <ø> (ø)`
src/sagemaker/pytorch/estimator.py	`92.30% <ø> (-7.70%)`	⬇️
src/sagemaker/pytorch/training_compiler/config.py	`84.61% <ø> (ø)`
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-27T20:48:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1f8964d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T21:01:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1f8964d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T21:08:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f8964d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T22:56:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1f8964d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* Update feature_group.py ingest() description Updating ingest function description (https://sagemaker.readthedocs.io/en/stable/api/prep_data/feature_store.html#sagemaker.feature_store.feature_group.FeatureGroup.ingest) according to discussion in a thread (https://amzn-aws.slack.com/archives/C02FT61K4BV/p1661876115110819). * documentation: get rid of white spaces

mwfongAWS requested a review from a team as a code owner January 26, 2023 22:40

mwfongAWS requested review from navinsoni and removed request for a team January 26, 2023 22:40

knikure assigned navinsoni Jan 27, 2023

claytonparnell reviewed Jan 27, 2023

View reviewed changes

documentation: get rid of white spaces

1f8964d

claytonparnell reviewed Jan 27, 2023

View reviewed changes

claytonparnell approved these changes Jan 27, 2023

View reviewed changes

claytonparnell merged commit a94a3b1 into aws:master Jan 28, 2023

mwfongAWS deleted the patch-1 branch January 30, 2023 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update feature_group.py ingest() description #3615

Update feature_group.py ingest() description #3615

mwfongAWS commented Jan 26, 2023 •

edited

Loading

claytonparnell left a comment

sagemaker-bot commented Jan 27, 2023

claytonparnell commented Jan 27, 2023

claytonparnell left a comment •

edited

Loading

sagemaker-bot commented Jan 27, 2023

sagemaker-bot commented Jan 27, 2023

sagemaker-bot commented Jan 27, 2023

sagemaker-bot commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023 •

edited

Loading

sagemaker-bot commented Jan 27, 2023

sagemaker-bot commented Jan 27, 2023

sagemaker-bot commented Jan 27, 2023

sagemaker-bot commented Jan 27, 2023

Update feature_group.py ingest() description #3615

Update feature_group.py ingest() description #3615

Conversation

mwfongAWS commented Jan 26, 2023 • edited Loading

Merge Checklist

General

Tests

claytonparnell left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

claytonparnell commented Jan 27, 2023

claytonparnell left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

codecov-commenter commented Jan 27, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

mwfongAWS commented Jan 26, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading

codecov-commenter commented Jan 27, 2023 •

edited

Loading