feature: Support for flexible instance types in the HPO #3611

repushko · 2023-01-25T10:33:59Z

Description of changes:
We want to support the flexible instance types, the feature which allows customers to override their instance types if one of the is now available.

Testing done:
Unit tests and integ tests are added

Merge Checklist

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

trajanikant

/bot run all

sagemaker-bot · 2023-01-25T21:46:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 01fa581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-25T21:50:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 01fa581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-25T22:20:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 01fa581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-25T22:46:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 01fa581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-25T22:49:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 01fa581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run all

sagemaker-bot · 2023-01-26T21:00:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e70c813
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T21:05:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e70c813
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T21:43:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e70c813
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T21:47:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e70c813
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T22:01:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e70c813
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell · 2023-01-27T18:04:12Z

Hi @repushko - to address the failing unit tests:

/home/docs/checkouts/readthedocs.org/user_builds/sagemaker/envs/3611/lib/python3.9/site-packages/sagemaker/tuner.py:docstring of sagemaker.tuner.HyperparameterTuner:10: WARNING: Unexpected indentation.
/home/docs/checkouts/readthedocs.org/user_builds/sagemaker/envs/3611/lib/python3.9/site-packages/sagemaker/tuner.py:docstring of sagemaker.tuner.HyperparameterTuner:13: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/docs/checkouts/readthedocs.org/user_builds/sagemaker/envs/3611/lib/python3.9/site-packages/sagemaker/session.py:docstring of sagemaker.session.Session.tune:126: WARNING: Unexpected indentation.
/home/docs/checkouts/readthedocs.org/user_builds/sagemaker/envs/3611/lib/python3.9/site-packages/sagemaker/session.py:docstring of sagemaker.session.Session.tune:128: WARNING: Bullet list ends without a blank line; unexpected unindent.

Could you also address merge conflicts before we can merge?

repushko · 2023-01-27T18:26:46Z

Yep, I'll take a look now

knikure

/bot run unit-tests, pr, slow-tests

sagemaker-bot · 2023-01-30T21:51:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 730d583
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T22:25:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 730d583
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T22:32:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 730d583
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T23:12:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 08e9218
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T23:18:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 08e9218
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T23:20:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 08e9218
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T23:21:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 08e9218
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T23:41:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 08e9218
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-30T23:41:26Z

Codecov Report

Merging #3611 (6238636) into master (1fa2377) will decrease coverage by 0.38%.
The diff coverage is 87.70%.

@@            Coverage Diff             @@
##           master    #3611      +/-   ##
==========================================
- Coverage   89.17%   88.79%   -0.38%     
==========================================
  Files         204      227      +23     
  Lines       18979    22344    +3365     
==========================================
+ Hits        16924    19841    +2917     
- Misses       2055     2503     +448

Impacted Files	Coverage Δ
src/sagemaker/dataset_definition/inputs.py	`100.00% <ø> (ø)`
src/sagemaker/debugger/framework_profile.py	`100.00% <ø> (ø)`
src/sagemaker/debugger/metrics_config.py	`100.00% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/lineage/_utils.py	`100.00% <ø> (+12.50%)`	⬆️
src/sagemaker/model_card/model_card.py	`93.04% <ø> (ø)`
src/sagemaker/model_card/schema_constraints.py	`100.00% <ø> (ø)`
src/sagemaker/model_monitor/__init__.py	`100.00% <ø> (ø)`
...agemaker/model_monitor/clarify_model_monitoring.py	`89.84% <ø> (-5.09%)`	⬇️
src/sagemaker/model_monitor/dataset_format.py	`72.72% <ø> (-2.28%)`	⬇️
... and 110 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-02-09T17:22:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 13d388b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T17:22:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 13d388b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run all

sagemaker-bot · 2023-02-09T18:33:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c7628fb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T18:35:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c7628fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T18:37:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c7628fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T19:02:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c7628fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T19:35:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c7628fb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T21:30:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c7628fb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T21:37:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c7628fb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T23:44:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6238636
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T23:47:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6238636
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T00:08:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6238636
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T01:55:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6238636
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T02:43:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6238636
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run pr, slow-tests

sagemaker-bot · 2023-02-10T17:31:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6238636
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T19:44:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6238636
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T20:25:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6238636
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T21:00:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6238636
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T21:08:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6238636
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T21:26:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6238636
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T23:35:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6238636
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Anton Repushko <[email protected]>

repushko requested a review from a team as a code owner January 25, 2023 10:34

repushko requested review from knikure and removed request for a team January 25, 2023 10:34

iaroslav-ai approved these changes Jan 25, 2023

View reviewed changes

trajanikant reviewed Jan 25, 2023

View reviewed changes

knikure assigned trajanikant Jan 26, 2023

trajanikant reviewed Jan 26, 2023

View reviewed changes

knikure reviewed Jan 30, 2023

View reviewed changes

knikure self-assigned this Jan 31, 2023

knikure reviewed Feb 9, 2023

View reviewed changes

feature: support for flexible instance types in the HPO

6238636

knikure reviewed Feb 10, 2023

View reviewed changes

knikure approved these changes Feb 10, 2023

View reviewed changes

knikure changed the title ~~feature: support for flexible instance types in the HPO~~ feature: Support for flexible instance types in the HPO Feb 10, 2023

knikure merged commit d2d377f into aws:master Feb 10, 2023

repushko deleted the hpo_flexible_instance_types branch February 10, 2023 20:46

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

feature: Support for flexible instance types in the HPO (aws#3611)

9810776

Co-authored-by: Anton Repushko <[email protected]>

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

feature: Support for flexible instance types in the HPO (aws#3611)

ed1559f

Co-authored-by: Anton Repushko <[email protected]>

feature: Support for flexible instance types in the HPO #3611

feature: Support for flexible instance types in the HPO #3611

Conversation

repushko commented Jan 25, 2023

Merge Checklist

General

Tests

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 25, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 25, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 25, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 25, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 25, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 26, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 26, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 26, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 26, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 26, 2023

AWS CodeBuild CI Report

claytonparnell commented Jan 27, 2023

repushko commented Jan 27, 2023

knikure left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 30, 2023

AWS CodeBuild CI Report

codecov-commenter commented Jan 30, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

knikure left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 10, 2023

knikure left a comment •

edited

Loading

codecov-commenter commented Jan 30, 2023 •

edited

Loading

knikure left a comment •

edited

Loading