Skip to content

fix: Remove confusing log line emitted during feature group ingestion #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/sagemaker/feature_store/feature_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,12 +365,10 @@ def _run_multi_threaded(
failed_indices = list()
for future in as_completed(futures, timeout=timeout):
start, end = futures[future]
result = future.result()
if result:
logger.error("Failed to ingest row %d to %d", start, end)
else:
failed_rows = future.result()
if not failed_rows:
logger.info("Successfully ingested row %d to %d", start, end)
failed_indices += result
failed_indices += failed_rows

executor.shutdown(wait=False)

Expand Down