feature: Add Extra Parameters to Lambda Function Wrapper #3594

dipanjank · 2023-01-17T09:33:42Z

Description of changes:

Add VpcConfig, Architectures, Environment and Layers parameters for boto3 Lambda create_function call.
Add Architectures for boto3 Lambda update_function call.

Testing done:

pytest -vs tests/unit/test_lambda_helper.py
================================================================================================= test session starts ==================================================================================================
platform darwin -- Python 3.7.11, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /Users/[email protected]/PycharmProjects/sagemaker-python-sdk-personal/venv/bin/python3
cachedir: .pytest_cache
rootdir: /Users/[email protected]/PycharmProjects/sagemaker-python-sdk-personal, configfile: tox.ini
plugins: forked-1.4.0, timeout-2.1.0, rerunfailures-10.2, xdist-2.4.0, anyio-3.6.2, cov-3.0.0
collected 28 items                                                                                                                                                                                                     

tests/unit/test_lambda_helper.py::test_lambda_object_with_arn_happycase PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_with_name_happycase1 PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_with_name_happycase2 PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_with_no_name_and_arn_error PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_no_code_error PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_both_script_and_code_dir_error_with_name PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_both_script_and_code_dir_error_with_arn PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_no_handler_error PASSED
tests/unit/test_lambda_helper.py::test_lambda_object_no_execution_role_error PASSED
tests/unit/test_lambda_helper.py::test_create_lambda_happycase1 PASSED
tests/unit/test_lambda_helper.py::test_create_lambda_happycase2 PASSED
tests/unit/test_lambda_helper.py::test_create_lambda_happycase3 PASSED
tests/unit/test_lambda_helper.py::test_create_lambda_no_function_name_error PASSED
tests/unit/test_lambda_helper.py::test_create_lambda_client_error PASSED
tests/unit/test_lambda_helper.py::test_update_lambda_happycase1 PASSED
tests/unit/test_lambda_helper.py::test_update_lambda_happycase2 PASSED
tests/unit/test_lambda_helper.py::test_update_lambda_happycase3 PASSED
tests/unit/test_lambda_helper.py::test_update_lambda_s3bucket_not_provided PASSED
tests/unit/test_lambda_helper.py::test_update_lambda_client_error PASSED
tests/unit/test_lambda_helper.py::test_upsert_lambda_happycase1 PASSED
tests/unit/test_lambda_helper.py::test_upsert_lambda_happycase2 PASSED
tests/unit/test_lambda_helper.py::test_upsert_lambda_client_error PASSED
tests/unit/test_lambda_helper.py::test_invoke_lambda_happycase PASSED
tests/unit/test_lambda_helper.py::test_invoke_lambda_client_error PASSED
tests/unit/test_lambda_helper.py::test_delete_lambda_happycase PASSED
tests/unit/test_lambda_helper.py::test_delete_lambda_client_error PASSED
tests/unit/test_lambda_helper.py::test_upload_to_s3 PASSED
tests/unit/test_lambda_helper.py::test_zip_lambda_code PASSED

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…CreateLambda operation

jpcpereira · 2023-02-07T20:18:24Z

Hi @dipanjank , nice PR, would be really great if you could include "Layers" to the additional inputs to create the Lambda function. This is also one of the options in Boto3. Would enable setting AWS Lambda Layers with extra useful libraries without having to zip & pass them.

dipanjank · 2023-02-07T21:17:24Z

Hi @dipanjank , nice PR, would be really great if you could include "Layers" to the additional inputs to create the Lambda function. This is also one of the options in Boto3. Would enable setting AWS Lambda Layers with extra useful libraries without having to zip & pass them.

Thanks for the review! sure.

knikure

/bot run all

sagemaker-bot · 2023-02-09T17:18:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6f13f15
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T17:58:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6f13f15
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T18:22:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6f13f15
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T18:29:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6f13f15
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-09T19:49:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6f13f15
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

@dipanjank Can you resolve the conflicts in your branch and rebase it over master?

dipanjank · 2023-02-23T08:56:00Z

@knikure sure, will do!

# Conflicts: # src/sagemaker/lambda_helper.py

dipanjank · 2023-02-23T22:30:55Z

/bot run all

dipanjank · 2023-02-23T22:49:25Z

Hi @knikure updated with latest from master + added the "layer" argument requested by @jpcpereira. Can you please review again?

knikure

/bot run all

knikure

/bot run all

sagemaker-bot · 2023-02-27T19:01:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a7d442d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-27T19:09:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a7d442d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-27T19:13:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a7d442d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-27T19:18:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a7d442d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-27T19:24:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a7d442d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-02-27T19:25:29Z

Codecov Report

Merging #3594 (7fb9f48) into master (0473a8e) will decrease coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
- Coverage   90.21%   89.45%   -0.76%     
==========================================
  Files         996      233     -763     
  Lines       94508    23383   -71125     
==========================================
- Hits        85257    20918   -64339     
+ Misses       9251     2465    -6786

Impacted Files	Coverage Δ
src/sagemaker/lambda_helper.py	`95.93% <100.00%> (ø)`

... and 1228 files with indirect coverage changes

knikure

/bot run all

sagemaker-bot · 2023-03-13T23:43:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7f1b945
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-14T00:22:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7f1b945
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-14T00:26:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7f1b945
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-14T00:35:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7f1b945
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-14T01:03:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7f1b945
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

dipanjank · 2023-03-29T11:57:16Z

Hi @knikure is there anything further I need to do to get this PR merged?

knikure

/bot run all

sagemaker-bot · 2023-04-26T21:12:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7fb9f48
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-26T21:16:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7fb9f48
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-26T21:23:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7fb9f48
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-26T21:39:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7fb9f48
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-26T22:53:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7fb9f48
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feature: Add VpcConfig, Architectures and Environment parameters for …

07443bb

…CreateLambda operation

dipanjank requested a review from a team as a code owner January 17, 2023 09:33

dipanjank requested review from knikure and removed request for a team January 17, 2023 09:33

dipanjank added 2 commits January 17, 2023 12:30

Fix existing test failures

d37df68

Add tests for new parameters added.

6f13f15

dipanjank changed the title ~~Add Extra Parameters to Lambda Function Wrapper~~ feature: Add Extra Parameters to Lambda Function Wrapper Jan 17, 2023

claytonparnell assigned claytonparnell and knikure and unassigned claytonparnell Jan 18, 2023

knikure linked an issue Feb 9, 2023 that may be closed by this pull request

Lambda boto3 wrappers doesn't have all the option that we need to create a lambda #3563

Closed

knikure reviewed Feb 9, 2023

View reviewed changes

knikure reviewed Feb 23, 2023

View reviewed changes

dipanjank added 3 commits February 23, 2023 23:10

Merge branch 'master' into feature-3563-add-lambda-func-parameters

15a1b8d

# Conflicts: # src/sagemaker/lambda_helper.py

Run black

b9955e8

Fix failing test

3dee69e

Add Lambda Layer argument

0181d9d

dipanjank requested a review from knikure February 26, 2023 10:11

Merge branch 'master' into feature-3563-add-lambda-func-parameters

a7d442d

knikure approved these changes Feb 27, 2023

View reviewed changes

knikure reviewed Feb 27, 2023

View reviewed changes

Merge branch 'master' into feature-3563-add-lambda-func-parameters

7f1b945

knikure reviewed Mar 13, 2023

View reviewed changes

dipanjank added 2 commits March 14, 2023 09:01

Merge branch 'master' into feature-3563-add-lambda-func-parameters

f92782d

Merge branch 'master' into feature-3563-add-lambda-func-parameters

7fb9f48

knikure reviewed Apr 26, 2023

View reviewed changes

knikure merged commit 239fc9d into aws:master Apr 27, 2023

dipanjank deleted the feature-3563-add-lambda-func-parameters branch April 28, 2023 08:53

hxrsmurf mentioned this pull request Apr 28, 2023

lambda_helper Lambda Is Not Able to Create - Requires VpcConfig #3826

Closed

feature: Add Extra Parameters to Lambda Function Wrapper #3594

feature: Add Extra Parameters to Lambda Function Wrapper #3594

Uh oh!

Conversation

dipanjank commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

jpcpereira commented Feb 7, 2023

Uh oh!

dipanjank commented Feb 7, 2023

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2023

AWS CodeBuild CI Report

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

dipanjank commented Feb 23, 2023

Uh oh!

dipanjank commented Feb 23, 2023

Uh oh!

dipanjank commented Feb 23, 2023

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 27, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 14, 2023

AWS CodeBuild CI Report

dipanjank commented Jan 17, 2023 •

edited

Loading

codecov-commenter commented Feb 27, 2023 •

edited

Loading