Freeze framework integ test to latest version #359
Conversation
tests/conftest.py
Outdated
| @@ -91,12 +91,12 @@ def chainer_version(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope='module', params=['1.4.1', '1.5.0', '1.6.0', '1.7.0', '1.8.0']) | |||
| @pytest.fixture(scope='module', params=['1.8.0']) | |||
There was a problem hiding this comment.
Should we use the DEFAULT_VERSION constant here to minimize duplication?
There was a problem hiding this comment.
Ah there's no duplicate here, for now each framework will only have one latest version always.
But seems get a LATEST_VERSION constant would be more clear to readers. I will apply that. Thanks!
There was a problem hiding this comment.
I was actually thinking about just use these - https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/mxnet/defaults.py#L15
There was a problem hiding this comment.
Then let me check if:
1, all frameworks have that
2, 1.2 and 1.2.1 can both work
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=========================================
+ Coverage 92.93% 93.1% +0.16%
=========================================
Files 51 51
Lines 3555 3555
=========================================
+ Hits 3304 3310 +6
+ Misses 251 245 -6
Continue to review full report at Codecov.
|
Correct typo to avoid confusion on number of endpoints
Issue #, if available:
Description of changes:
Freeze the framework integ test to latest version.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.