Skip to content

Add batch transform integ tests #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Conversation

laurenyu
Copy link
Contributor

Description of changes:
This change introduces a couple batch transform integ tests. Since there is the general implementation of transformer() with EstimatorBase as well as one specific to Framework, I added one test for each of the two implementations. One of the tests also covers Transformer.attach().

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu laurenyu requested a review from iquintero August 16, 2018 16:00
@codecov-io
Copy link

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          51       51           
  Lines        3552     3552           
=======================================
  Hits         3301     3301           
  Misses        251      251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae15a6...fb89dc6. Read the comment docs.

@laurenyu laurenyu merged commit 4613f24 into aws:master Aug 16, 2018
@laurenyu laurenyu deleted the batch-integ-test branch August 16, 2018 19:47
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants