feat: locations for EMR configuration and Spark dependencies #3486

leandrolcampos · 2022-11-24T01:05:19Z

Issue #, if available: #3200

Description of changes:
This PR gives the user the possibility to specify, when initializing objects of PySparkProcessor and SparkJarProcessor classes, where the EMR application configuration and Spark dependencies will be uploaded. It is inspired by the code_location parameter of the FrameworkProcessor class.

Testing done:
export IGNORE_COVERAGE=- ; tox -e py310 -- -s -vv tests/unit/sagemaker/spark/test_processing.py ; unset IGNORE_COVERAGE

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vikas0203

/bot run all

vikas0203

/bot run all

sagemaker-bot · 2022-12-19T20:55:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-19T20:55:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-19T21:31:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 549a719
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-19T21:44:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-19T21:55:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 549a719
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run pr

sagemaker-bot · 2022-12-20T04:31:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

leandrolcampos · 2023-01-31T10:17:06Z

Hi @vikas0203 and @claytonparnell,

I hope this message finds you well. Please let me know if I have something to change in this PR.

All the best,

vikas0203

/bot run slow-tests,pr

vikas0203

/bot run unit-tests

sagemaker-bot · 2023-02-10T23:29:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-10T23:31:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-11T05:24:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 549a719
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

leandrolcampos · 2023-02-27T23:02:55Z

Hi @vikas0203 and @knikure,

I hope this message finds you well. Please let me know if I have something to change in this PR.

All the best,

claytonparnell · 2023-03-02T18:26:35Z

Hi @leandrolcampos - very sorry this has been pending for so long. It looks like there are some style issues, could you run tox -e black-format and tox -e flake8 to resolve the issues? Then we will try to get this merged in.

leandrolcampos · 2023-03-02T23:27:12Z

Hi @claytonparnell,

I addressed your comment. Can you please review the PR again?

Thank you very much for your guidance!

leandrolcampos · 2023-03-08T16:23:05Z

Hi @claytonparnell,

I hope this message finds you well. Please let me know if I have something to change in this PR.

All the best,

claytonparnell

/bot run all

sagemaker-bot · 2023-03-10T18:29:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d5a913a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T18:36:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d5a913a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T18:46:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d5a913a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-03-10T18:46:47Z

Codecov Report

Merging #3486 (d5a913a) into master (1f37c6d) will decrease coverage by 1.02%.
The diff coverage is 100.00%.

❗ Current head d5a913a differs from pull request most recent head ec553fd. Consider uploading reports for the commit ec553fd to get more accurate results

@@            Coverage Diff             @@
##           master    #3486      +/-   ##
==========================================
- Coverage   89.84%   88.82%   -1.02%     
==========================================
  Files         984      205     -779     
  Lines       92312    19471   -72841     
==========================================
- Hits        82936    17296   -65640     
+ Misses       9376     2175    -7201

Impacted Files	Coverage Δ
src/sagemaker/spark/processing.py	`98.39% <100.00%> (ø)`

... and 1188 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-03-10T19:42:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d5a913a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T20:42:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d5a913a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

leandrolcampos · 2023-03-20T21:34:56Z

Hi @claytonparnell,

Please let me know if I have something to change in this PR.

claytonparnell

/bot run slow-tests

sagemaker-bot · 2023-03-21T16:48:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ec553fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T16:57:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ec553fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T17:01:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ec553fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T17:05:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ec553fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T17:34:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ec553fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T19:36:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ec553fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-21T19:44:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ec553fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-22T00:25:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ec553fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…3486) * feat: locations for EMR configuration and Spark dependencies * Fix style issues

navinsoni requested review from a team, claytonparnell and vikas0203 and removed request for a team December 1, 2022 21:56

mufaddal-rohawala assigned vikas0203 Dec 19, 2022

vikas0203 approved these changes Dec 19, 2022

View reviewed changes

vikas0203 reviewed Dec 19, 2022

View reviewed changes

mufaddal-rohawala requested a review from a team as a code owner December 20, 2022 00:31

vikas0203 reviewed Dec 20, 2022

View reviewed changes

vikas0203 reviewed Feb 10, 2023

View reviewed changes

claytonparnell self-assigned this Mar 2, 2023

claytonparnell reviewed Mar 10, 2023

View reviewed changes

claytonparnell force-pushed the spark_location branch from d5a913a to 799213d Compare March 13, 2023 18:17

leandrolcampos added 2 commits March 21, 2023 12:08

feat: locations for EMR configuration and Spark dependencies

7dfe79a

Fix style issues

ec553fd

claytonparnell force-pushed the spark_location branch from 799213d to ec553fd Compare March 21, 2023 16:08

claytonparnell reviewed Mar 21, 2023

View reviewed changes

claytonparnell merged commit 4fb7c01 into aws:master Mar 22, 2023

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

feature: locations for EMR configuration and Spark dependencies (aws#…

238c111

…3486) * feat: locations for EMR configuration and Spark dependencies * Fix style issues

This was referenced Sep 21, 2023

Custom s3 path for uploading spark configuration files #3200

Closed

passing configuration for spark processing job #3732

Closed

feat: locations for EMR configuration and Spark dependencies #3486

feat: locations for EMR configuration and Spark dependencies #3486

Conversation

leandrolcampos commented Nov 24, 2022 • edited Loading

Merge Checklist

General

Tests

vikas0203 left a comment

Choose a reason for hiding this comment

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 19, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 20, 2022

AWS CodeBuild CI Report

leandrolcampos commented Jan 31, 2023 • edited Loading

vikas0203 left a comment

Choose a reason for hiding this comment

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Feb 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 11, 2023

AWS CodeBuild CI Report

leandrolcampos commented Feb 27, 2023

claytonparnell commented Mar 2, 2023

leandrolcampos commented Mar 2, 2023

leandrolcampos commented Mar 8, 2023

claytonparnell left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

codecov-commenter commented Mar 10, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

leandrolcampos commented Mar 20, 2023

claytonparnell left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 22, 2023

AWS CodeBuild CI Report

leandrolcampos commented Nov 24, 2022 •

edited

Loading

leandrolcampos commented Jan 31, 2023 •

edited

Loading

codecov-commenter commented Mar 10, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading