change: add neo mvp region accounts #3485

HappyAmazonian · 2022-11-23T22:11:01Z

Issue #, if available:
Adding DCA/LCK Neo Configurations

Description of changes:
Adding DCA/LCK Neo Configurations

Testing done:
Ran unit tests successfully locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

navinsoni

/bot run all

sagemaker-bot · 2022-11-24T00:07:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0afe0ab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T00:11:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0afe0ab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T00:21:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0afe0ab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T00:26:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0afe0ab
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-11-24T00:26:52Z

Codecov Report

Merging #3485 (f2d2c26) into master (1fa2377) will decrease coverage by 0.20%.
The diff coverage is 88.30%.

@@            Coverage Diff             @@
##           master    #3485      +/-   ##
==========================================
- Coverage   89.17%   88.96%   -0.21%     
==========================================
  Files         204      212       +8     
  Lines       18979    20435    +1456     
==========================================
+ Hits        16924    18180    +1256     
- Misses       2055     2255     +200

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_group.py	`76.52% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/pipeline.py	`85.33% <ø> (ø)`
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
...sagemaker/workflow/monitor_batch_transform_step.py	`0.00% <0.00%> (ø)`
src/sagemaker/xgboost/model.py	`96.36% <ø> (-1.82%)`	⬇️
...agemaker/model_monitor/clarify_model_monitoring.py	`89.84% <27.58%> (-5.09%)`	⬇️
src/sagemaker/training_compiler/config.py	`80.43% <60.00%> (-2.90%)`	⬇️
src/sagemaker/pytorch/estimator.py	`94.73% <63.63%> (-5.27%)`	⬇️
src/sagemaker/sklearn/estimator.py	`93.93% <63.63%> (-6.07%)`	⬇️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-11-24T00:35:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0afe0ab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run all

sagemaker-bot · 2022-12-01T18:07:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f2d2c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T18:23:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f2d2c26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T18:27:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f2d2c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T18:53:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f2d2c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T20:38:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2d2c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run slow-tests, pr, local-tests, notebook-tests

sagemaker-bot · 2022-12-01T22:39:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f2d2c26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-01T22:46:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f2d2c26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T00:38:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2d2c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run local-mode-tests, slow-tests

sagemaker-bot · 2022-12-02T02:40:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f2d2c26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T04:50:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2d2c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2022-12-02T18:23:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2d2c26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Mufaddal Rohawala <[email protected]>

change: add neo mvp region accounts

0afe0ab

HappyAmazonian force-pushed the neo-dca-lck branch from dbf4a80 to 0afe0ab Compare November 23, 2022 22:13

HappyAmazonian changed the title ~~add neo mvp region accounts~~ change: add neo mvp region accounts Nov 23, 2022

doomsbuster approved these changes Nov 23, 2022

View reviewed changes

navinsoni reviewed Nov 23, 2022

View reviewed changes

ravishankar-sivaraman approved these changes Nov 25, 2022

View reviewed changes

Merge branch 'master' into neo-dca-lck

f2d2c26

mufaddal-rohawala self-assigned this Dec 1, 2022

mufaddal-rohawala approved these changes Dec 1, 2022

View reviewed changes

mufaddal-rohawala reviewed Dec 1, 2022

View reviewed changes

navinsoni approved these changes Dec 1, 2022

View reviewed changes

mufaddal-rohawala reviewed Dec 1, 2022

View reviewed changes

mufaddal-rohawala reviewed Dec 2, 2022

View reviewed changes

mufaddal-rohawala merged commit a96e5ef into aws:master Dec 2, 2022

HappyAmazonian mentioned this pull request Dec 2, 2022

Adding DCA/LCK Neo Configurations #3368

Closed

mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022

change: add neo mvp region accounts (aws#3485)

66eb5e2

Co-authored-by: Mufaddal Rohawala <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

change: add neo mvp region accounts (aws#3485)

39fe771

Co-authored-by: Mufaddal Rohawala <[email protected]>

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

change: add neo mvp region accounts (aws#3485)

2e37a4b

Co-authored-by: Mufaddal Rohawala <[email protected]>

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

change: add neo mvp region accounts (aws#3485)

359a40a

Co-authored-by: Mufaddal Rohawala <[email protected]>

change: add neo mvp region accounts #3485

change: add neo mvp region accounts #3485

Uh oh!

Conversation

HappyAmazonian commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

navinsoni left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Nov 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 1, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

HappyAmazonian commented Nov 23, 2022 •

edited

Loading

codecov-commenter commented Nov 24, 2022 •

edited

Loading