Skip to content

feat: add support for PT1.12.1 #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2022
Merged

feat: add support for PT1.12.1 #3468

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32318ec
support for PT1.12.1
tejaschumbalkar Nov 10, 2022
8ac0894
address comments
tejaschumbalkar Nov 11, 2022
1c8806f
fix pytorch json
tejaschumbalkar Nov 11, 2022
0e39546
fix: point notebook tests platform to notebook-al2-v2
mufaddal-rohawala Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sagemaker/fw_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@
"1.11.0",
"1.12",
"1.12.0",
"1.12.1",
],
}

Expand All @@ -134,6 +135,7 @@
"1.11.0",
"1.12",
"1.12.0",
"1.12.1",
]


Expand Down
68 changes: 66 additions & 2 deletions src/sagemaker/image_uri_config/pytorch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"1.9": "1.9.1",
"1.10": "1.10.2",
"1.11": "1.11.0",
"1.12": "1.12.0"
"1.12": "1.12.1"
},
"versions": {
"0.4.0": {
Expand Down Expand Up @@ -650,6 +650,38 @@
"us-west-1": "763104351884",
"us-west-2": "763104351884"
},
"1.12.1": {
"py_versions": [
"py38"
],
"registries": {
"af-south-1": "626614931356",
"ap-east-1": "871362719292",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
"ap-southeast-2": "763104351884",
"ap-southeast-3": "907027046896",
"ca-central-1": "763104351884",
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-north-1": "763104351884",
"eu-west-1": "763104351884",
"eu-west-2": "763104351884",
"eu-west-3": "763104351884",
"eu-south-1": "692866216735",
"me-south-1": "217643126080",
"sa-east-1": "763104351884",
"us-east-1": "763104351884",
"us-east-2": "763104351884",
"us-gov-west-1": "442386744353",
"us-iso-east-1": "886529160074",
"us-west-1": "763104351884",
"us-west-2": "763104351884"
},
"repository": "pytorch-inference"
}
}
Expand Down Expand Up @@ -718,7 +750,7 @@
"1.9": "1.9.1",
"1.10": "1.10.2",
"1.11": "1.11.0",
"1.12": "1.12.0"
"1.12": "1.12.1"
},
"versions": {
"0.4.0": {
Expand Down Expand Up @@ -1301,6 +1333,38 @@
"us-west-1": "763104351884",
"us-west-2": "763104351884"
},
"1.12.1": {
"py_versions": [
"py38"
],
"registries": {
"af-south-1": "626614931356",
"ap-east-1": "871362719292",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
"ap-southeast-2": "763104351884",
"ap-southeast-3": "907027046896",
"ca-central-1": "763104351884",
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-north-1": "763104351884",
"eu-west-1": "763104351884",
"eu-west-2": "763104351884",
"eu-west-3": "763104351884",
"eu-south-1": "692866216735",
"me-south-1": "217643126080",
"sa-east-1": "763104351884",
"us-east-1": "763104351884",
"us-east-2": "763104351884",
"us-gov-west-1": "442386744353",
"us-iso-east-1": "886529160074",
"us-west-1": "763104351884",
"us-west-2": "763104351884"
},
"repository": "pytorch-training"
}
}
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_fw_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,7 @@ def test_validate_smdataparallel_args_not_raises():
("ml.p3.16xlarge", "pytorch", "1.11.0", "py38", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "1.11", "py38", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "1.12.0", "py38", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "1.12.1", "py38", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "1.12", "py38", smdataparallel_enabled),
("ml.p3.16xlarge", "tensorflow", "2.4.1", "py3", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "tensorflow", "2.4.1", "py37", smdataparallel_enabled_custom_mpi),
Expand All @@ -882,6 +883,7 @@ def test_validate_smdataparallel_args_not_raises():
("ml.p3.16xlarge", "pytorch", "1.10.2", "py38", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "pytorch", "1.11.0", "py38", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "pytorch", "1.12.0", "py38", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "pytorch", "1.12.1", "py38", smdataparallel_enabled_custom_mpi),
]
for instance_type, framework_name, framework_version, py_version, distribution in good_args:
fw_utils._validate_smdataparallel_args(
Expand Down Expand Up @@ -917,6 +919,7 @@ def test_validate_pytorchddp_not_raises():
"1.11.0",
"1.12",
"1.12.0",
"1.12.1",
]
for framework_version in pytorchddp_supported_fw_versions:
fw_utils.validate_pytorch_distribution(
Expand Down