Skip to content

PipeModeDataset code block example improvements #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

nkconnor
Copy link
Contributor

Changes

  • removed duplicate PipeModeDataset instantiation
  • wrapped usage in train_input_fn to match other examples

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* removed duplicate `PipeModeDataset` instantiation
* wrap usage in `train_input_fn` to match other examples
@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #346   +/-   ##
======================================
  Coverage    93.1%   93.1%           
======================================
  Files          51      51           
  Lines        3552    3552           
======================================
  Hits         3307    3307           
  Misses        245     245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dc3b5...4803933. Read the comment docs.

@ChoiByungWook ChoiByungWook merged commit 6ac8f08 into aws:master Aug 14, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants