-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Fixing type hints for Spark processor that has instance type/count params in reverse order #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing type hints for Spark processor that has instance type/count params in reverse order #3444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run all
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…rams in reverse order
296cd0d
to
cd2a305
Compare
…nt params in reverse order (aws#3444)
…nt params in reverse order (aws#3444)
…nt params in reverse order (aws#3444)
…nt params in reverse order (aws#3444)
Issue #, if available:
#3167
Description of changes:
SparkProcessor and SparkJarProcessor, unlike all other processors, have instance_type and instance_count in constructor in reverse order. When the type hints were added in #3167, they were probably copy-pasted from other processors, hence str and int type hints got assigned in reverse order by mistake.
This is the fix to get correct type hints only, without changing the order of parameters and without breaking the backward compatibility.
Testing done:
Yes
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.