fix: Fix Repack step auto install behavior #3419

qidewenwhen · 2022-10-17T20:32:21Z

Issue #, if available: #3143

Description of changes:

Add a launcher.sh to launch the repack model script in the repack step, which is able to disable the auto install behavior regarding the user supplied requirements.txt, which is targeted for the subsequent step rather than the repack step.

Testing done: Unit tests and integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-10-17T20:36:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 89b9a02
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-17T20:41:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 89b9a02
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-17T20:54:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4c1a309
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-17T21:33:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4c1a309
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-17T21:45:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4c1a309
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-17T21:55:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4c1a309
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-17T23:37:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4c1a309
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T00:07:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 88aad8b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T00:08:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 88aad8b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T00:23:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e5337a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T00:27:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9e5337a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T01:07:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9e5337a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T01:28:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9e5337a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T01:32:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9e5337a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-18T01:59:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e5337a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:02:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2ddd6b4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:38:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2ddd6b4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:45:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4d236f2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:48:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4d236f2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T18:14:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4d236f2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T18:27:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4d236f2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-10-19T18:44:07Z

Codecov Report

Merging #3419 (0dea793) into master (1fa2377) will decrease coverage by 0.21%.
The diff coverage is 83.22%.

@@            Coverage Diff             @@
##           master    #3419      +/-   ##
==========================================
- Coverage   89.17%   88.95%   -0.22%     
==========================================
  Files         204      205       +1     
  Lines       18979    19076      +97     
==========================================
+ Hits        16924    16969      +45     
- Misses       2055     2107      +52

Impacted Files	Coverage Δ
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
...sagemaker/workflow/monitor_batch_transform_step.py	`0.00% <0.00%> (ø)`
src/sagemaker/workflow/utilities.py	`94.31% <ø> (ø)`
src/sagemaker/xgboost/model.py	`96.36% <ø> (-1.82%)`	⬇️
src/sagemaker/session.py	`71.41% <28.57%> (-0.25%)`	⬇️
src/sagemaker/training_compiler/config.py	`80.43% <60.00%> (-2.90%)`	⬇️
src/sagemaker/sklearn/estimator.py	`93.93% <63.63%> (-6.07%)`	⬇️
src/sagemaker/estimator.py	`89.43% <71.42%> (-0.08%)`	⬇️
src/sagemaker/amazon/amazon_estimator.py	`87.82% <81.25%> (-0.62%)`	⬇️
src/sagemaker/amazon/lda.py	`98.03% <92.30%> (+0.16%)`	⬆️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-10-19T19:23:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0dea793
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T19:38:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0dea793
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T19:56:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0dea793
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T21:40:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0dea793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T22:31:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0dea793
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-20T02:39:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0dea793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-20T18:22:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0dea793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T01:56:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0dea793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T03:15:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0dea793
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* fix: Fix Repack step auto install behavior * fix doc8 and unit tests Co-authored-by: Dewen Qi <[email protected]>

qidewenwhen force-pushed the master branch from 89b9a02 to 4c1a309 Compare October 17, 2022 20:45

qidewenwhen requested a review from navaj0 October 17, 2022 20:46

staubhp approved these changes Oct 17, 2022

View reviewed changes

qidewenwhen force-pushed the master branch from 4c1a309 to 88aad8b Compare October 18, 2022 00:03

qidewenwhen force-pushed the master branch from 88aad8b to 9e5337a Compare October 18, 2022 00:18

mufaddal-rohawala approved these changes Oct 18, 2022

View reviewed changes

qidewenwhen force-pushed the master branch from 9e5337a to 2ddd6b4 Compare October 19, 2022 16:53

fix: Fix Repack step auto install behavior

57f1370

qidewenwhen force-pushed the master branch from 2ddd6b4 to 4d236f2 Compare October 19, 2022 17:42

fix doc8 and unit tests

0dea793

qidewenwhen force-pushed the master branch from 4d236f2 to 0dea793 Compare October 19, 2022 18:49

claytonparnell merged commit b267f1e into aws:master Oct 21, 2022

brockwade633 pushed a commit to brockwade633/sagemaker-python-sdk that referenced this pull request Oct 26, 2022

fix: Fix Repack step auto install behavior (aws#3419)

ea5a0f5

* fix: Fix Repack step auto install behavior * fix doc8 and unit tests Co-authored-by: Dewen Qi <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

fix: Fix Repack step auto install behavior (aws#3419)

6960f3f

* fix: Fix Repack step auto install behavior * fix doc8 and unit tests Co-authored-by: Dewen Qi <[email protected]>

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

fix: Fix Repack step auto install behavior (aws#3419)

6b12bf9

* fix: Fix Repack step auto install behavior * fix doc8 and unit tests Co-authored-by: Dewen Qi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix Repack step auto install behavior #3419

fix: Fix Repack step auto install behavior #3419

qidewenwhen commented Oct 17, 2022 •

edited

Loading

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 17, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 18, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

codecov-commenter commented Oct 19, 2022 •

edited

Loading

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 19, 2022

sagemaker-bot commented Oct 20, 2022

sagemaker-bot commented Oct 20, 2022

sagemaker-bot commented Oct 21, 2022

sagemaker-bot commented Oct 21, 2022

fix: Fix Repack step auto install behavior #3419

fix: Fix Repack step auto install behavior #3419

Conversation

qidewenwhen commented Oct 17, 2022 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

codecov-commenter commented Oct 19, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

qidewenwhen commented Oct 17, 2022 •

edited

Loading

codecov-commenter commented Oct 19, 2022 •

edited

Loading