feat: Support KeepAlivePeriodInSeconds for Training APIs #3371

SifeiLi · 2022-09-21T06:10:34Z

Issue #, if available:

Description of changes: feature: support KeepAlivePeriodInSeconds for training job

Testing done:

Unit tests passing
Tested with updated json model in SageMaker Notebooks

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This reverts commit e442d35.

sagemaker-bot · 2022-09-23T23:35:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ebc0c2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-09-23T23:36:20Z

Codecov Report

Merging #3371 (ebd5f2c) into master (b4ea839) will decrease coverage by 0.86%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #3371      +/-   ##
==========================================
- Coverage   90.01%   89.15%   -0.87%     
==========================================
  Files         868      204     -664     
  Lines       76892    18997   -57895     
==========================================
- Hits        69213    16936   -52277     
+ Misses       7679     2061    -5618

Impacted Files	Coverage Δ
src/sagemaker/session.py	`71.41% <0.00%> (ø)`
src/sagemaker/estimator.py	`89.43% <71.42%> (ø)`
src/sagemaker/job.py	`90.13% <100.00%> (ø)`
...ython3.10/site-packages/sagemaker/lambda_helper.py
...3.10/site-packages/sagemaker/lineage/_api_types.py
...on3.9/site-packages/sagemaker/workflow/entities.py
...-packages/sagemaker/debugger/profiler_constants.py
...hon3.10/site-packages/sagemaker/mxnet/estimator.py
...9/site-packages/sagemaker/drift_check_baselines.py
...gemaker/cli/compatibility/v2/modifiers/modifier.py
... and 1065 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-09-23T23:49:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ebc0c2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-24T00:11:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ebc0c2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-24T00:22:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ebc0c2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-24T01:05:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ebc0c2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

… master

sagemaker-bot · 2022-09-26T17:24:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8479a01
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T17:51:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8479a01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T18:04:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8479a01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T18:05:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8479a01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T18:49:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T18:55:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:06:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:19:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:28:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T23:41:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T23:41:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T23:41:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T23:42:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T00:09:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ebd5f2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

Support KeepAlivePeriodInSeconds for Training APIs

vikas0203

Support KeepAlivePeriodInSeconds for Training APIs

SifeiLi added 5 commits September 20, 2022 23:07

Support KeepAlivePeriodInSeconds for Training APIs

c226952

edited keep alive docstrings

e442d35

Revert "edited keep alive docstrings"

4ceb076

This reverts commit e442d35.

Fix

e098545

Merge branch 'master' into master

ebc0c2f

SifeiLi added 2 commits September 26, 2022 10:18

Fix docstrings

fef30ac

Merge branch 'master' of github.com:SifeiLi/sagemaker-python-sdk into…

8479a01

… master

typo fix

ebd5f2c

mufaddal-rohawala approved these changes Sep 26, 2022

View reviewed changes

mufaddal-rohawala changed the title ~~Support KeepAlivePeriodInSeconds for Training APIs~~ feat: Support KeepAlivePeriodInSeconds for Training APIs Sep 26, 2022

mufaddal-rohawala merged commit 322b919 into aws:master Sep 26, 2022

vikas0203 self-requested a review October 4, 2022 00:06

vikas0203 reviewed Oct 4, 2022

View reviewed changes

vikas0203 requested review from vikas0203 and removed request for vikas0203 October 4, 2022 00:10

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

feat: Support KeepAlivePeriodInSeconds for Training APIs (aws#3371)

4837dde

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support KeepAlivePeriodInSeconds for Training APIs #3371

feat: Support KeepAlivePeriodInSeconds for Training APIs #3371

SifeiLi commented Sep 21, 2022 •

edited

Loading

sagemaker-bot commented Sep 23, 2022

codecov-commenter commented Sep 23, 2022 •

edited

Loading

sagemaker-bot commented Sep 23, 2022

sagemaker-bot commented Sep 24, 2022

sagemaker-bot commented Sep 24, 2022

sagemaker-bot commented Sep 24, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 26, 2022

sagemaker-bot commented Sep 27, 2022

vikas0203 left a comment

vikas0203 left a comment

feat: Support KeepAlivePeriodInSeconds for Training APIs #3371

feat: Support KeepAlivePeriodInSeconds for Training APIs #3371

Conversation

SifeiLi commented Sep 21, 2022 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

codecov-commenter commented Sep 23, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

vikas0203 left a comment

Choose a reason for hiding this comment

SifeiLi commented Sep 21, 2022 •

edited

Loading

codecov-commenter commented Sep 23, 2022 •

edited

Loading