fix: Pass KMS value to create processing job in S3 bucket with restrictions #3366

raj-oli · 2022-09-19T02:25:43Z

Issue #, if available:

Description of changes:

When using an S3 bucket with a policy that restricts PUT objects unless a kms key is specified, the creation of a processing job fails due to the fact that the SDK doesn't pass the value to all sections of the code. This change will fix that.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-09-29T00:32:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-09-29T00:33:07Z

Codecov Report

Merging #3366 (f791330) into master (20cffd6) will decrease coverage by 0.75%.
The diff coverage is n/a.

❗ Current head f791330 differs from pull request most recent head 5a62b7b. Consider uploading reports for the commit 5a62b7b to get more accurate results

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   89.89%   89.14%   -0.75%     
==========================================
  Files        1060      204     -856     
  Lines      101188    19010   -82178     
==========================================
- Hits        90962    16947   -74015     
+ Misses      10226     2063    -8163

Impacted Files	Coverage Δ
src/sagemaker/processing.py	`94.33% <ø> (ø)`

... and 1263 files with indirect coverage changes

sagemaker-bot · 2022-09-29T00:33:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T00:47:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T00:52:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T01:07:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f791330
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T01:09:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f791330
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T01:10:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T01:19:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T01:21:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-29T01:29:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f791330
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

raj-oli · 2022-10-13T03:57:47Z

What would be the estimated timeframe for this PR to be merged ?

vikas0203

/bot run all

sagemaker-bot · 2022-10-25T23:05:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T23:06:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T23:06:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T23:08:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run slow-tests,unit-tests

vikas0203

/bot run pr,local-mode-tests

sagemaker-bot · 2022-10-26T00:08:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T00:08:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 293017a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T00:09:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203 · 2022-10-26T00:09:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests

Commit ID: 293017a

Result: FAILED

Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Looks like a syntax error on Line no 1693

sagemaker-bot · 2022-10-26T00:09:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T00:56:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 293017a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T19:56:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: aebc834
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T20:15:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: aebc834
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T20:23:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aebc834
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T20:24:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aebc834
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run notebook-tests

vikas0203

/bot run unit-tests

sagemaker-bot · 2022-12-02T23:48:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: aebc834
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T23:49:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aebc834
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-03T00:46:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: aebc834
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run unit-tests,slow-tests

sagemaker-bot · 2022-12-05T17:37:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: aebc834
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T20:27:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aebc834
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2023-04-27T17:15:35Z

@raj-oli Can you resolve the conflicts in the PR?

…ctions

raj-oli · 2023-04-27T22:29:19Z

@raj-oli Can you resolve the conflicts in the PR?

Done

knikure

/bot run all

knikure · 2023-04-27T22:31:03Z

@raj-oli Can you resolve the conflicts in the PR?

Done

Is there any existing open GitHub issue related to this issue. Feel free to link it?

sagemaker-bot · 2023-04-27T22:35:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5a62b7b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-27T23:17:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5a62b7b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-27T23:24:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5a62b7b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-27T23:26:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5a62b7b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-28T01:31:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5a62b7b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-05-09T00:44:40Z

src/sagemaker/processing.py

@@ -1804,7 +1805,7 @@ def _pack_and_upload_code(
            raise RuntimeError("S3 source_dir file must be named `sourcedir.tar.gz.`")

        script = estimator.uploaded_code.script_name
-        s3_runproc_sh = self._create_and_upload_runproc(script, kms_key, entrypoint_s3_uri)
+        s3_runproc_sh = self._create_and_upload_runproc(script, self.output_kms_key, entrypoint_s3_uri)


@raj-oli thanks for the contribution, but what if a custom kms key is set by the method argument kms_key, I think we need to set kms_key = self.output_kms_key if kms_key=None

@mufaddal-rohawala. Thanks for the heads up. You're right !!.
I'll close this PR as you've already merged the fix. Thank you

claytonparnell force-pushed the raj-bug-fix branch from f791330 to 293017a Compare October 19, 2022 17:13

vikas0203 reviewed Oct 25, 2022

View reviewed changes

vikas0203 approved these changes Oct 26, 2022

View reviewed changes

vikas0203 reviewed Oct 26, 2022

View reviewed changes

raj-oli force-pushed the raj-bug-fix branch from 293017a to 04ed2b3 Compare October 26, 2022 00:33

raj-oli requested a review from vikas0203 October 26, 2022 00:34

vikas0203 requested a review from a team November 23, 2022 21:18

vikas0203 reviewed Dec 2, 2022

View reviewed changes

vikas0203 reviewed Dec 5, 2022

View reviewed changes

mufaddal-rohawala requested a review from a team as a code owner December 20, 2022 00:31

mufaddal-rohawala approved these changes Apr 11, 2023

View reviewed changes

fix: Pass KMS value to create processing job in S3 bucket with restri…

5a62b7b

…ctions

raj-oli force-pushed the raj-bug-fix branch from aebc834 to 5a62b7b Compare April 27, 2023 22:27

knikure reviewed Apr 27, 2023

View reviewed changes

knikure assigned knikure and unassigned vikas0203 Apr 27, 2023

mufaddal-rohawala reviewed May 9, 2023

View reviewed changes

mufaddal-rohawala mentioned this pull request May 9, 2023

fix: Pass KMS value to create processing job #3843

Merged

9 tasks

raj-oli closed this May 12, 2023

fix: Pass KMS value to create processing job in S3 bucket with restrictions #3366

fix: Pass KMS value to create processing job in S3 bucket with restrictions #3366

Conversation

raj-oli commented Sep 19, 2022

Merge Checklist

General

Tests

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

codecov-commenter commented Sep 29, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

raj-oli commented Oct 13, 2022

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Oct 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 26, 2022

AWS CodeBuild CI Report

vikas0203 commented Oct 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

vikas0203 left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

codecov-commenter commented Sep 29, 2022 •

edited

Loading

vikas0203 left a comment •

edited

Loading