fix: Two letter language code must be supported #3258

keerthanvasist · 2022-07-21T17:33:46Z

Description of changes:
Two letter language code must be supported

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

goswamig · 2022-07-21T18:45:15Z

src/sagemaker/clarify.py

@@ -426,68 +426,131 @@ class TextConfig:
    _SUPPORTED_GRANULARITIES = ["token", "sentence", "paragraph"]
    _SUPPORTED_LANGUAGES = [
        "chinese",
+        "zh",


how are we coming up with this list?

These are the ISO two letter language codes for the supported languages.

what I meant is, is this a full list or some of them?

This is a full list of supported languages. Not full list of all languages.

ok, so are we limited by support by some underlying library or we have some restriction on our side?
Also whats the plan for keeping them up to date?

Yes. We are limited by an underlying library. The update has to be manual.

sagemaker-bot · 2022-07-26T19:30:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 42993f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-07-26T19:33:43Z

Codecov Report

Merging #3258 (fa89e94) into master (95bbe7a) will decrease coverage by 0.79%.
The diff coverage is n/a.

❗ Current head fa89e94 differs from pull request most recent head 6895d1c. Consider uploading reports for the commit 6895d1c to get more accurate results

@@            Coverage Diff             @@
##           master    #3258      +/-   ##
==========================================
- Coverage   89.77%   88.97%   -0.80%     
==========================================
  Files         645      203     -442     
  Lines       55209    18172   -37037     
==========================================
- Hits        49565    16169   -33396     
+ Misses       5644     2003    -3641

Impacted Files	Coverage Δ
src/sagemaker/clarify.py	`95.43% <ø> (ø)`
...lib/python3.8/site-packages/sagemaker/algorithm.py
...r/cli/compatibility/v2/modifiers/tf_legacy_mode.py
...on3.7/site-packages/sagemaker/workflow/pipeline.py
...ib/python3.7/site-packages/sagemaker/local/data.py
...agemaker/cli/compatibility/v2/modifiers/parsing.py
...3.8/site-packages/sagemaker/jumpstart/artifacts.py
...ages/sagemaker/feature_store/feature_definition.py
...hon3.9/site-packages/sagemaker/lineage/artifact.py
...maker/cli/compatibility/v2/sagemaker_upgrade_v2.py
... and 839 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95bbe7a...6895d1c. Read the comment docs.

sagemaker-bot · 2022-07-26T19:39:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 42993f8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T19:52:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 42993f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T20:14:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 42993f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T20:21:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 42993f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T05:17:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 42993f8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T21:04:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 42993f8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T21:21:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 42993f8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

larroy

LGTM

larroy

Maybe also change the language parameter documentation saying that 2 letter ISO code is also accepted?

sagemaker-bot · 2022-07-27T22:13:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ff0134f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T22:45:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2242c72
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T23:20:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2242c72
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T23:25:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2242c72
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T23:26:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2242c72
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T23:55:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7a331ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T00:17:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7a331ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T00:23:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7a331ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T00:25:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7a331ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T00:41:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7a331ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T03:52:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7a331ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T17:43:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3700965
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T18:03:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3700965
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T18:08:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3700965
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T18:23:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3700965
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-28T18:34:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3700965
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T17:09:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fa89e94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T17:18:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fa89e94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T17:30:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fa89e94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T17:55:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: fa89e94
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T19:34:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fa89e94
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T20:20:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6895d1c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T20:37:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6895d1c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T20:42:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6895d1c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T21:00:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6895d1c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-29T22:45:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6895d1c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-01T23:49:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fbac304
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-02T00:11:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fbac304
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-02T00:25:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fbac304
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-02T00:31:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fbac304
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-02T00:33:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: fbac304
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-02T02:10:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fbac304
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

goswamig reviewed Jul 21, 2022

View reviewed changes

keerthanvasist force-pushed the lang branch 2 times, most recently from fe4a341 to fe5af4f Compare July 26, 2022 17:43

mufaddal-rohawala approved these changes Jul 27, 2022

View reviewed changes

larroy approved these changes Jul 27, 2022

View reviewed changes

larroy reviewed Jul 27, 2022

View reviewed changes

keerthanvasist force-pushed the lang branch from 2242c72 to 7a331ee Compare July 27, 2022 23:29

keerthanvasist force-pushed the lang branch from 7a331ee to 3700965 Compare July 28, 2022 17:15

larroy approved these changes Jul 28, 2022

View reviewed changes

keerthanvasist force-pushed the lang branch from fa89e94 to 6895d1c Compare July 29, 2022 19:52

fix: Two letter language code must be supported

fbac304

navinsoni force-pushed the lang branch from 6895d1c to fbac304 Compare August 1, 2022 23:21

navinsoni merged commit 60562db into aws:master Aug 2, 2022

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Aug 4, 2022

fix: Two letter language code must be supported (aws#3258)

1bed823

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

fix: Two letter language code must be supported (aws#3258)

23d5885

fix: Two letter language code must be supported #3258

fix: Two letter language code must be supported #3258

Conversation

keerthanvasist commented Jul 21, 2022

Merge Checklist

General

Tests

goswamig Jul 21, 2022

Choose a reason for hiding this comment

keerthanvasist Jul 21, 2022

Choose a reason for hiding this comment

goswamig Jul 21, 2022

Choose a reason for hiding this comment

keerthanvasist Jul 21, 2022

Choose a reason for hiding this comment

goswamig Jul 21, 2022

Choose a reason for hiding this comment

keerthanvasist Jul 21, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jul 26, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

larroy left a comment

Choose a reason for hiding this comment

larroy left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 29, 2022

codecov-commenter commented Jul 26, 2022 •

edited

Loading