test: Vspecinteg2 #3249

BasilBeirouti · 2022-07-19T02:59:02Z

Issue #, if available:
Adding an integration test that requires some ECR permissions. Those ECR permissions are added to the pull request role here:
https://code.amazon.com/reviews/CR-71433937/revisions/3#/diff

Description of changes:

This integration test checks that creating a model package is possible by passing a validation spec. Note that our Prod account is hardcoded to not allow network isolation:
https://code.amazon.com/packages/MaeveControlPlaneService/blobs/mainline/--/src/com/amazonaws/services/ironman/validation/NetworkIsolationValidator.java

This makes model package created by my integration test complete, but in a failed state. This does not happen in my personal stack, only in dev-prod account. It does not affect the integration test, since the model package still creates successfully.

Testing done:

Testing in personal stack as well as on dev prod account

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-07-19T03:00:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4d9d7b8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-19T03:33:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4d9d7b8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-19T03:47:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4d9d7b8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-19T04:21:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4d9d7b8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-19T06:01:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4d9d7b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-20T20:14:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4d9d7b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

1 minor change, otherwise LGTM

tests/integ/test_marketplace.py

sagemaker-bot · 2022-07-22T02:03:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4d9d7b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:20:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8f736c9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:22:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8f736c9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T20:00:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9c0b413
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-07-22T20:03:05Z

Codecov Report

Merging #3249 (9c0b413) into master (b4f05b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3249   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         203      203           
  Lines       17978    17978           
=======================================
  Hits        15963    15963           
  Misses       2015     2015

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f05b8...9c0b413. Read the comment docs.

sagemaker-bot · 2022-07-22T20:21:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9c0b413
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T20:22:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9c0b413
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T20:26:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9c0b413
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T20:41:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9c0b413
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T21:57:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9c0b413
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T21:59:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9c0b413
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-25T22:30:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9c0b413
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Basil Beirouti <[email protected]>

Basil Beirouti added 9 commits July 18, 2022 15:26

integration test

a5c51e0

adding integration test for model package marketplace feature

2692bd2

black-check formatting changes

df9c5a4

changed repo source from dockerhub to ECR

9bd4b59

fixed exception catching in _delete_repository

e277444

flake8 formatting

2da9dcd

fix repository not found exception

6569753

remove extra whitespace

61b95fa

removed hardcoded role and replaced with boto3 call

4d9d7b8

mufaddal-rohawala requested changes Jul 21, 2022

View reviewed changes

tests/integ/test_marketplace.py Show resolved Hide resolved

fixed model naming to use unique_name_from_base

9c0b413

BasilBeirouti force-pushed the vspecinteg2 branch from 8f736c9 to 9c0b413 Compare July 22, 2022 19:32

BasilBeirouti requested a review from mufaddal-rohawala July 27, 2022 23:01

mufaddal-rohawala approved these changes Jul 27, 2022

View reviewed changes

mufaddal-rohawala merged commit 79b3e9d into aws:master Jul 27, 2022

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Aug 4, 2022

test: Vspecinteg2 (aws#3249)

cf915c8

Co-authored-by: Basil Beirouti <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

test: Vspecinteg2 (aws#3249)

62a72b3

Co-authored-by: Basil Beirouti <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Vspecinteg2 #3249

test: Vspecinteg2 #3249

BasilBeirouti commented Jul 19, 2022 •

edited

Loading

sagemaker-bot commented Jul 19, 2022

sagemaker-bot commented Jul 19, 2022

sagemaker-bot commented Jul 19, 2022

sagemaker-bot commented Jul 19, 2022

sagemaker-bot commented Jul 19, 2022

sagemaker-bot commented Jul 20, 2022

mufaddal-rohawala left a comment

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

codecov-commenter commented Jul 22, 2022 •

edited

Loading

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

sagemaker-bot commented Jul 25, 2022

test: Vspecinteg2 #3249

test: Vspecinteg2 #3249

Conversation

BasilBeirouti commented Jul 19, 2022 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Jul 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 20, 2022

AWS CodeBuild CI Report

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jul 22, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 25, 2022

AWS CodeBuild CI Report

BasilBeirouti commented Jul 19, 2022 •

edited

Loading

codecov-commenter commented Jul 22, 2022 •

edited

Loading