feature: Allow customizing trial component display names for pipeline launched jobs #3230

navaj0 · 2022-07-12T15:30:48Z

…aunched jobs

Issue #, if available:

Description of changes: Allow users to customize trial component display names for pipeline launched jobs

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-07-12T15:58:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 44d29b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-07-12T16:02:56Z

Codecov Report

Merging #3230 (8e2e677) into master (38b4916) will decrease coverage by 0.36%.
The diff coverage is 96.68%.

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   89.40%   89.04%   -0.37%     
==========================================
  Files         848      203     -645     
  Lines       72563    18296   -54267     
==========================================
- Hits        64877    16292   -48585     
+ Misses       7686     2004    -5682

Impacted Files	Coverage Δ
src/sagemaker/inputs.py	`100.00% <ø> (ø)`
src/sagemaker/jumpstart/types.py	`94.37% <0.00%> (ø)`
src/sagemaker/processing.py	`94.33% <ø> (ø)`
src/sagemaker/transformer.py	`94.47% <ø> (ø)`
src/sagemaker/workflow/step_collections.py	`93.87% <ø> (ø)`
src/sagemaker/job.py	`90.00% <75.00%> (-0.55%)`	⬇️
src/sagemaker/chainer/model.py	`96.49% <88.88%> (-1.07%)`	⬇️
src/sagemaker/estimator.py	`89.55% <90.00%> (-0.04%)`	⬇️
src/sagemaker/mxnet/model.py	`98.41% <90.00%> (+2.04%)`	⬆️
src/sagemaker/pytorch/model.py	`96.82% <90.00%> (+11.37%)`	⬆️
... and 694 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-07-12T16:18:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 44d29b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T16:20:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 44d29b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T16:23:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 44d29b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T16:38:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 44d29b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shreyapandit · 2022-07-12T17:11:30Z

src/sagemaker/workflow/steps.py

-        request_dict.pop("ExperimentConfig", None)
+
+        # only keep the trial component name
+        if request_dict.get("ExperimentConfig", {}).get("TrialComponentDisplayName"):
+            request_dict["ExperimentConfig"] = {
+                "TrialComponentDisplayName": request_dict["ExperimentConfig"][
+                    "TrialComponentDisplayName"
+                ]
+            }
+        else:
+            request_dict.pop("ExperimentConfig", None)


This is an entirely repeated block of code, can we refactor this?

shreyapandit · 2022-07-12T17:11:55Z

src/sagemaker/workflow/steps.py

+
+        # only keep the trial component name
+        if request_dict.get("ExperimentConfig", {}).get("TrialComponentDisplayName"):
+            request_dict["ExperimentConfig"] = {
+                "TrialComponentDisplayName": request_dict["ExperimentConfig"][
+                    "TrialComponentDisplayName"
+                ]
+            }
+        else:
+            request_dict.pop("ExperimentConfig", None)
+


same here, maybe worth having a outside utils entity?

Yes. Refactored it out.

shreyapandit · 2022-07-12T17:12:32Z

tests/data/_repack_model.py

+import argparse
+import os
+import shutil
+import tarfile


Why aren't we using existing repack from the SDK?

Thanks for catching this. It is actually generated by the tests but not cleaned up somehow.

sagemaker-bot · 2022-07-12T17:58:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f4d3adc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T18:04:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f4d3adc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T18:35:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eaf35a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T18:37:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f4d3adc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T18:43:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: eaf35a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T18:53:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eaf35a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T19:00:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f4d3adc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T19:16:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: eaf35a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T19:19:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: eaf35a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-12T20:49:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f4d3adc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-15T15:19:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: eaf35a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-15T16:20:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: eaf35a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-26T04:41:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: eaf35a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen · 2022-07-26T16:05:01Z

src/sagemaker/transformer.py

@@ -194,6 +197,11 @@ def transform(
                (default: ``True``).
            logs (bool): Whether to show the logs produced by the job.
                Only meaningful when wait is ``True`` (default: ``True``).
+            kms_key (str): The ARN of the KMS key that is used to encrypt the


Don't see the kms_key in the .transform() signature. Why we add it here in doc string?

Copy/Paste error. Removed it.

sagemaker-bot · 2022-08-04T18:54:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4f5cf1e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T19:35:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4f5cf1e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T19:45:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4f5cf1e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T19:57:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4f5cf1e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aunched jobs

sagemaker-bot · 2022-08-04T21:19:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8e2e677
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T21:38:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8e2e677
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T21:48:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8e2e677
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T21:53:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8e2e677
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-04T23:42:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8e2e677
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-14T01:05:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8e2e677
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-14T02:17:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8e2e677
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aunched jobs (aws#3230) Co-authored-by: Zhankui Lu <[email protected]>

shreyapandit changed the title ~~feature: Allow users to customize trial component display names for pipeline launched jobs~~ feature: Allow customizing trial component display names for pipeline launched jobs Jul 12, 2022

shreyapandit reviewed Jul 12, 2022

View reviewed changes

shreyapandit added the needs contributor changes label Jul 12, 2022

navaj0 force-pushed the usability branch from 44d29b9 to f4d3adc Compare July 12, 2022 17:53

navaj0 force-pushed the usability branch from f4d3adc to eaf35a7 Compare July 12, 2022 18:08

qidewenwhen reviewed Jul 26, 2022

View reviewed changes

navaj0 force-pushed the usability branch from eaf35a7 to 4f5cf1e Compare August 4, 2022 18:50

Allow users to customize trial component display names for pipeline l…

8e2e677

…aunched jobs

navaj0 force-pushed the usability branch from 4f5cf1e to 8e2e677 Compare August 4, 2022 20:49

qidewenwhen approved these changes Aug 8, 2022

View reviewed changes

navaj0 removed the needs contributor changes label Aug 8, 2022

shreyapandit merged commit 02fdf1b into aws:master Aug 15, 2022

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

Allow users to customize trial component display names for pipeline l…

875d0cb

…aunched jobs (aws#3230) Co-authored-by: Zhankui Lu <[email protected]>

feature: Allow customizing trial component display names for pipeline launched jobs #3230

feature: Allow customizing trial component display names for pipeline launched jobs #3230

Uh oh!

Conversation

navaj0 commented Jul 12, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

shreyapandit Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

shreyapandit Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

navaj0 Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

shreyapandit Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

navaj0 Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 26, 2022

codecov-commenter commented Jul 12, 2022 •

edited

Loading