Skip to content

Update doc for parameter source_dir #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Jul 31, 2018

Issue #, if available:
#312

Description of changes:
README is not accurate for usage of source_dir. The entry point file should be in source_dir too.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested review from andremoeller and laurenyu July 31, 2018 00:39
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #323 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   92.92%   93.08%   +0.16%     
==========================================
  Files          51       51              
  Lines        3560     3560              
==========================================
+ Hits         3308     3314       +6     
+ Misses        252      246       -6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 89.44% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394bb3c...bdfc019. Read the comment docs.

@yangaws yangaws merged commit 8051399 into aws:master Aug 3, 2018
@yangaws yangaws deleted the source_dir_readme branch August 3, 2018 05:47
jnclt pushed a commit to jnclt/sagemaker-python-sdk that referenced this pull request Aug 3, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants