feat: Add target_model to support multi-model endpoints #3215

keerthanvasist · 2022-07-06T21:11:29Z

Issue #, if available:
Add target_model to support multi-model endpoints in Clarify processing jobs.

Testing done:
Added unit tests.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

goswamig · 2022-07-06T21:15:05Z

src/sagemaker/clarify.py

@@ -185,6 +185,7 @@ def __init__(
        custom_attributes=None,
        accelerator_type=None,
        endpoint_name_prefix=None,
+        target_model=None,


is this a required param?

sagemaker-bot · 2022-07-06T21:16:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a465efc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T21:49:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a465efc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T21:57:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7fa4dce
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T21:59:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7fa4dce
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:00:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a465efc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:17:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a465efc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:18:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a465efc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:24:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6d66407
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:25:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6d66407
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:30:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6d66407
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:36:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 080556e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T22:37:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7fa4dce
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:00:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7fa4dce
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:04:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 080556e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:08:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6d66407
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:15:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 080556e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:21:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 080556e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:28:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6d66407
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:33:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 80292a1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T23:38:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 080556e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

goswamig · 2022-07-06T23:38:35Z

src/sagemaker/clarify.py

@@ -218,6 +219,8 @@ def __init__(
                https://docs.aws.amazon.com/sagemaker/latest/dg/ei.html.
            endpoint_name_prefix (str): The endpoint name prefix of a new endpoint. Must follow
                pattern "^[a-zA-Z0-9](-\*[a-zA-Z0-9]".
+            target_model (str): Sets the target model name when using a multi-model endpoint. For
+            more information about multi-model endpoints


I think you want to add link of multi-model endpoints.

goswamig

I think you want to add link of multi-model endpoints.

goswamig

LGTM

sagemaker-bot · 2022-07-06T23:53:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 80292a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-07-06T23:53:36Z

Codecov Report

Merging #3215 (4dfd31c) into master (4879ec3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3215   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         203      203           
  Lines       17913    17914    +1     
=======================================
+ Hits        15912    15913    +1     
  Misses       2001     2001

Impacted Files	Coverage Δ
src/sagemaker/clarify.py	`95.04% <100.00%> (+0.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4879ec3...4dfd31c. Read the comment docs.

sagemaker-bot · 2022-07-07T00:12:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8e62581
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T00:13:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 80292a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T00:19:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8e62581
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T00:32:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8e62581
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T00:34:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 80292a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T00:50:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8e62581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T02:37:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8e62581
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T18:22:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4dfd31c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T18:31:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4dfd31c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T18:43:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4dfd31c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T18:58:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4dfd31c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T20:48:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4dfd31c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T22:48:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4dfd31c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-09T00:35:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4dfd31c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-09T00:44:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4dfd31c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-09T02:19:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4dfd31c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

goswamig reviewed Jul 6, 2022

View reviewed changes

keerthanvasist force-pushed the target branch from a465efc to 7fa4dce Compare July 6, 2022 21:52

keerthanvasist force-pushed the target branch from 7fa4dce to 6d66407 Compare July 6, 2022 22:19

keerthanvasist force-pushed the target branch from 6d66407 to 080556e Compare July 6, 2022 22:31

keerthanvasist force-pushed the target branch from 080556e to 80292a1 Compare July 6, 2022 23:26

goswamig reviewed Jul 6, 2022

View reviewed changes

goswamig suggested changes Jul 6, 2022

View reviewed changes

keerthanvasist force-pushed the target branch from 80292a1 to 8e62581 Compare July 6, 2022 23:44

goswamig approved these changes Jul 6, 2022

View reviewed changes

Satish615 approved these changes Jul 7, 2022

View reviewed changes

feat: Add target_model to support multi-model endpoints

4dfd31c

keerthanvasist force-pushed the target branch from 8e62581 to 4dfd31c Compare July 8, 2022 17:54

navinsoni approved these changes Jul 8, 2022

View reviewed changes

mufaddal-rohawala approved these changes Jul 11, 2022

View reviewed changes

mufaddal-rohawala merged commit a5464a2 into aws:master Jul 11, 2022

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

feat: Add target_model to support multi-model endpoints (aws#3215)

8cf8fa0

feat: Add target_model to support multi-model endpoints #3215

feat: Add target_model to support multi-model endpoints #3215

Conversation

keerthanvasist commented Jul 6, 2022

Merge Checklist

General

Tests

goswamig Jul 6, 2022

Choose a reason for hiding this comment

keerthanvasist Jul 6, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

goswamig Jul 6, 2022

Choose a reason for hiding this comment

goswamig left a comment

Choose a reason for hiding this comment

goswamig left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jul 6, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

codecov-commenter commented Jul 6, 2022 •

edited

Loading