Skip to content

fix: model table link #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022
Merged

fix: model table link #3211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8284aa2
fix: model table link
evakravi Jul 5, 2022
c343271
Merge branch 'master' into fix/model-table-link
evakravi Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/jumpstart/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def _get_manifest_key_from_model_id_semantic_version(

error_msg = f"Unable to find model manifest for '{model_id}' with version '{version}'. "
error_msg += (
"Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/jumpstart.html"
"Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/pretrainedmodels.html"
" for updated list of models. "
)

Expand Down
6 changes: 3 additions & 3 deletions tests/unit/sagemaker/jumpstart/test_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test_jumpstart_cache_get_header():
)
assert (
"Unable to find model manifest for 'pytorch-ic-imagenet-inception-v3-classification-4' with "
"version '3.*'. Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/jumpstart.html "
"version '3.*'. Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/pretrainedmodels.html "
"for updated list of models. Consider using model ID 'pytorch-ic-imagenet-inception-v3-"
"classification-4' with version '2.0.0'."
) in str(e.value)
Expand All @@ -172,7 +172,7 @@ def test_jumpstart_cache_get_header():
cache.get_header(model_id="pytorch-ic-", semantic_version_str="*")
assert (
"Unable to find model manifest for 'pytorch-ic-' with version '*'. "
"Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/jumpstart.html "
"Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/pretrainedmodels.html "
"for updated list of models. "
"Did you mean to use model ID 'pytorch-ic-imagenet-inception-v3-classification-4'?"
) in str(e.value)
Expand All @@ -181,7 +181,7 @@ def test_jumpstart_cache_get_header():
cache.get_header(model_id="tensorflow-ic-", semantic_version_str="*")
assert (
"Unable to find model manifest for 'tensorflow-ic-' with version '*'. "
"Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/jumpstart.html "
"Visit https://sagemaker.readthedocs.io/en/stable/doc_utils/pretrainedmodels.html "
"for updated list of models. "
"Did you mean to use model ID 'tensorflow-ic-imagenet-inception-"
"v3-classification-4'?"
Expand Down